refactor: закрыть замечания Sonar в main, redis и health

- Вынес API v1 префикс в константу

- Упростил get_redis до синхронной зависимости

- Перевел health dependencies на Annotated

Author: RomanVetrov

app/main.py

@@ -13,6 +13,8 @@
 from app.routes.tasks import router as tasks_router
 from app.telemetry import setup_telemetry, shutdown_telemetry
 
+API_V1_PREFIX = "/api/v1"
+
 
 @asynccontextmanager
 async def lifespan(app: FastAPI):
@@ -42,7 +44,7 @@ async def lifespan(app: FastAPI):
 app.add_middleware(RequestIDMiddleware)
 
 app.include_router(metrics_router)
-app.include_router(auth_router, prefix="/api/v1")
-app.include_router(health_router, prefix="/api/v1")
-app.include_router(tasks_router, prefix="/api/v1")
-app.include_router(tags_router, prefix="/api/v1")
+app.include_router(auth_router, prefix=API_V1_PREFIX)
+app.include_router(health_router, prefix=API_V1_PREFIX)
+app.include_router(tasks_router, prefix=API_V1_PREFIX)
+app.include_router(tags_router, prefix=API_V1_PREFIX)

app/redis.py

@@ -9,5 +9,5 @@
 )
 
 
-async def get_redis() -> Redis:
+def get_redis() -> Redis:
     return redis_client

app/routes/health.py

@@ -1,4 +1,4 @@
-from typing import Awaitable, cast
+from typing import Annotated, Awaitable, cast
 
 from fastapi import APIRouter, Depends
 from redis.asyncio import Redis
@@ -9,15 +9,17 @@
 from app.redis import get_redis
 
 router = APIRouter(prefix="/health", tags=["health"])
+RedisClient = Annotated[Redis, Depends(get_redis)]
+DbSession = Annotated[AsyncSession, Depends(get_db)]
 
 
 @router.get("/redis")
-async def redis_health(redis: Redis = Depends(get_redis)) -> dict[str, str]:
+async def redis_health(redis: RedisClient) -> dict[str, str]:
     ok = await cast(Awaitable[bool], redis.ping())
     return {"redis": "ok" if ok else "down"}
 
 
 @router.get("/db")
-async def db_health(session: AsyncSession = Depends(get_db)) -> dict[str, str]:
+async def db_health(session: DbSession) -> dict[str, str]:
     await session.execute(text("SELECT 1"))
     return {"db": "ok"}