skill publishing fixes

Author: clavery

.changeset/fix-skills-release-resolution.md

@@ -0,0 +1,5 @@
+---
+'@salesforce/b2c-tooling-sdk': patch
+---
+
+Fix skills version resolution to correctly parse release tags and invalidate cached version on download errors

.changeset/fix-skills-release-workflow.md

@@ -0,0 +1,5 @@
+---
+'@salesforce/b2c-agent-plugins': patch
+---
+
+Fix skills artifact download by publishing zip assets to dedicated agent-plugins releases

.github/workflows/publish.yml

@@ -395,7 +395,7 @@ jobs:
         if: steps.release-type.outputs.type == 'stable' && steps.changesets.outputs.skip != 'true' && steps.quick-check.outputs.skip != 'true'
         run: |
           # Determine the release tag — prefer CLI as the user-facing product.
-          # VSX is excluded: it gets its own dedicated release to avoid tag collisions.
+          # Plugins and VSX get their own dedicated releases, so they are excluded here.
           if [[ "${{ steps.packages.outputs.publish_cli }}" == "true" ]]; then
             RELEASE_TAG="@salesforce/b2c-cli@${{ steps.packages.outputs.version_cli }}"
           elif [[ "${{ steps.packages.outputs.publish_sdk }}" == "true" ]]; then
@@ -406,10 +406,8 @@ jobs:
             RELEASE_TAG="@salesforce/mrt-utilities@${{ steps.packages.outputs.version_mrt }}"
           elif [[ "${{ steps.packages.outputs.publish_docs }}" == "true" ]]; then
             RELEASE_TAG="docs@${{ steps.packages.outputs.version_docs }}"
-          elif [[ "${{ steps.packages.outputs.publish_plugins }}" == "true" ]]; then
-            RELEASE_TAG="b2c-agent-plugins@${{ steps.packages.outputs.version_plugins }}"
           else
-            echo "No non-VSX packages published, skipping main release"
+            echo "No non-VSX/non-plugins packages published, skipping main release"
             exit 0
           fi
 
@@ -421,7 +419,6 @@ jobs:
           [[ "${{ steps.packages.outputs.publish_mrt }}" == "true" ]] && TITLE_PARTS+=("mrt-utilities ${{ steps.packages.outputs.version_mrt }}")
           [[ "${{ steps.packages.outputs.publish_vsx }}" == "true" ]] && TITLE_PARTS+=("b2c-vs-extension ${{ steps.packages.outputs.version_vsx }}")
           [[ "${{ steps.packages.outputs.publish_docs }}" == "true" ]] && TITLE_PARTS+=("docs ${{ steps.packages.outputs.version_docs }}")
-          [[ "${{ steps.packages.outputs.publish_plugins }}" == "true" ]] && TITLE_PARTS+=("agent-plugins ${{ steps.packages.outputs.version_plugins }}")
           RELEASE_TITLE="Version Packages — $(IFS=', '; echo "${TITLE_PARTS[*]}")"
 
           gh release create "$RELEASE_TAG" --title "$RELEASE_TITLE" --notes-file /tmp/release-notes.md
@@ -443,20 +440,11 @@ jobs:
       - name: Upload skills to release
         if: steps.release-type.outputs.type == 'stable' && steps.changesets.outputs.skip != 'true' && steps.quick-check.outputs.skip != 'true' && steps.packages.outputs.publish_plugins == 'true'
         run: |
-          # Determine the release tag (same priority as Create GitHub Release, excludes VSX)
-          if [[ "${{ steps.packages.outputs.publish_cli }}" == "true" ]]; then
-            RELEASE_TAG="@salesforce/b2c-cli@${{ steps.packages.outputs.version_cli }}"
-          elif [[ "${{ steps.packages.outputs.publish_sdk }}" == "true" ]]; then
-            RELEASE_TAG="@salesforce/b2c-tooling-sdk@${{ steps.packages.outputs.version_sdk }}"
-          elif [[ "${{ steps.packages.outputs.publish_mcp }}" == "true" ]]; then
-            RELEASE_TAG="@salesforce/b2c-dx-mcp@${{ steps.packages.outputs.version_mcp }}"
-          elif [[ "${{ steps.packages.outputs.publish_mrt }}" == "true" ]]; then
-            RELEASE_TAG="@salesforce/mrt-utilities@${{ steps.packages.outputs.version_mrt }}"
-          elif [[ "${{ steps.packages.outputs.publish_docs }}" == "true" ]]; then
-            RELEASE_TAG="docs@${{ steps.packages.outputs.version_docs }}"
-          else
-            RELEASE_TAG="b2c-agent-plugins@${{ steps.packages.outputs.version_plugins }}"
-          fi
+          RELEASE_TAG="b2c-agent-plugins@${{ steps.packages.outputs.version_plugins }}"
+
+          gh release create "$RELEASE_TAG" \
+            --title "Agent Plugins ${{ steps.packages.outputs.version_plugins }}" \
+            --notes "Skills artifacts for b2c-agent-plugins v${{ steps.packages.outputs.version_plugins }}"
 
           gh release upload "$RELEASE_TAG" b2c-skills.zip b2c-cli-skills.zip
         env:

packages/b2c-tooling-sdk/src/skills/github.ts

@@ -52,6 +52,15 @@ function writeLatestVersionCache(version: string): void {
   }
 }
 
+function clearLatestVersionCache(): void {
+  try {
+    const p = getLatestVersionCachePath();
+    if (fs.existsSync(p)) fs.unlinkSync(p);
+  } catch {
+    // Best-effort
+  }
+}
+
 function isRateLimited(response: Response): boolean {
   if (response.status !== 403 && response.status !== 429) return false;
   const remaining = response.headers.get('x-ratelimit-remaining');
@@ -130,9 +139,12 @@ function parseRelease(release: {
   const b2cAsset = release.assets.find((a) => a.name === b2cSource.assetName);
   const b2cCliAsset = release.assets.find((a) => a.name === b2cCliSource.assetName);
 
+  const versionMatch = release.tag_name.match(/@(\d+\.\d+\.\d+.*)$/);
+  const version = versionMatch ? versionMatch[1] : release.tag_name.replace(/^v/, '');
+
   return {
     tagName: release.tag_name,
-    version: release.tag_name.replace(/^v/, ''),
+    version,
     publishedAt: release.published_at,
     b2cSkillsAssetUrl: b2cAsset?.browser_download_url ?? null,
     b2cCliSkillsAssetUrl: b2cCliAsset?.browser_download_url ?? null,
@@ -167,6 +179,7 @@ export async function getRelease(version: string = 'latest'): Promise<ReleaseInf
   });
 
   if (!response.ok) {
+    clearLatestVersionCache();
     if (response.status === 404) {
       throw new Error(`Release not found: ${tag}`);
     }
@@ -212,7 +225,10 @@ export async function listReleases(limit: number = 10): Promise<ReleaseInfo[]> {
     assets: Array<{name: string; browser_download_url: string}>;
   }>;
 
-  return data.map(parseRelease).filter((r) => r.b2cSkillsAssetUrl || r.b2cCliSkillsAssetUrl);
+  return data
+    .filter((r) => r.tag_name.startsWith('b2c-agent-plugins@'))
+    .map(parseRelease)
+    .filter((r) => r.b2cSkillsAssetUrl || r.b2cCliSkillsAssetUrl);
 }
 
 /**
@@ -264,6 +280,7 @@ async function downloadReleaseArtifact(
   });
 
   if (!response.ok) {
+    clearLatestVersionCache();
     if (response.status === 404) {
       throw new Error(`Skills artifact '${source.assetName}' not found for release ${tag}`);
     }