Add extended mcp telemetry.start() tests

Author: allison-grady

packages/b2c-dx-mcp/package.json

@@ -106,16 +106,19 @@
     "@types/chai": "^4",
     "@types/mocha": "^10",
     "@types/node": "^22.16.5",
+    "@types/sinon": "^21.0.0",
     "chai": "^4",
     "eslint": "^9",
     "eslint-config-oclif": "^6",
     "eslint-config-prettier": "^10",
     "eslint-plugin-header": "^3.1.1",
     "eslint-plugin-prettier": "^5.5.4",
+    "esmock": "^2.7.3",
     "mocha": "^10",
     "oclif": "^4",
     "prettier": "^3.6.2",
     "shx": "^0.3.3",
+    "sinon": "^21.0.1",
     "tsx": "^4",
     "typescript": "^5",
     "typescript-eslint": "^8"

packages/b2c-dx-mcp/test/commands/mcp.test.ts

@@ -5,6 +5,8 @@
  */
 
 import {expect} from 'chai';
+import sinon from 'sinon';
+import esmock from 'esmock';
 import McpServerCommand from '../../src/commands/mcp.js';
 
 describe('McpServerCommand', () => {
@@ -96,4 +98,154 @@ describe('McpServerCommand', () => {
       }
     });
   });
+
+  describe('telemetry initialization', () => {
+    let sandbox: sinon.SinonSandbox;
+
+    beforeEach(() => {
+      sandbox = sinon.createSandbox();
+    });
+
+    afterEach(() => {
+      sandbox.restore();
+    });
+
+    it('should call createTelemetry and telemetry.start() when SFCC_TELEMETRY is not false', async () => {
+      // Create mock telemetry instance
+      const mockTelemetry = {
+        start: sandbox.stub().resolves(),
+        stop: sandbox.stub(),
+        sendEvent: sandbox.stub(),
+        addAttributes: sandbox.stub(),
+      };
+
+      // Use esmock to mock the ES module imports
+      const MockedMcpServerCommand = await esmock('../../src/commands/mcp.js', {
+        '@salesforce/b2c-tooling-sdk/telemetry': {
+          createTelemetry: sandbox.stub().returns(mockTelemetry),
+        },
+        '../../src/server.js': {
+          B2CDxMcpServer: class MockServer {
+            async connect() {
+              /* no-op */
+            }
+          },
+        },
+      });
+
+      // Ensure telemetry is not disabled
+      const originalEnv = process.env.SFCC_TELEMETRY;
+      delete process.env.SFCC_TELEMETRY;
+
+      try {
+        // Create command instance
+        const command = new MockedMcpServerCommand.default([], {
+          name: 'test',
+          version: '1.0.0',
+          root: process.cwd(),
+        });
+
+        // Stub init to set up flags
+        sandbox.stub(command, 'init').resolves();
+        (command as unknown as {flags: Record<string, unknown>}).flags = {
+          'allow-non-ga-tools': false,
+          'log-level': 'silent',
+        };
+
+        // Stub resolvedConfig with required methods
+        sandbox.stub(command, 'resolvedConfig').get(() => ({
+          values: {},
+          hasMrtConfig: () => false,
+          hasB2CInstanceConfig: () => false,
+          hasOAuth: () => false,
+          hasBasicAuth: () => false,
+        }));
+
+        // Stub logger
+        sandbox.stub(command, 'logger').get(() => ({info: sandbox.stub()}));
+
+        // Run the command
+        await command.run();
+
+        // Verify telemetry.start() was called
+        expect(mockTelemetry.start.calledOnce).to.be.true;
+      } finally {
+        // Restore env
+        if (originalEnv !== undefined) {
+          process.env.SFCC_TELEMETRY = originalEnv;
+        }
+      }
+    });
+
+    it('should not initialize telemetry when SFCC_TELEMETRY is false', async () => {
+      // Create mock telemetry instance
+      const mockTelemetry = {
+        start: sandbox.stub().resolves(),
+        stop: sandbox.stub(),
+        sendEvent: sandbox.stub(),
+        addAttributes: sandbox.stub(),
+      };
+
+      const createTelemetryStub = sandbox.stub().returns(mockTelemetry);
+
+      // Use esmock to mock the ES module imports
+      const MockedMcpServerCommand = await esmock('../../src/commands/mcp.js', {
+        '@salesforce/b2c-tooling-sdk/telemetry': {
+          createTelemetry: createTelemetryStub,
+        },
+        '../../src/server.js': {
+          B2CDxMcpServer: class MockServer {
+            async connect() {
+              /* no-op */
+            }
+          },
+        },
+      });
+
+      // Disable telemetry via env
+      const originalEnv = process.env.SFCC_TELEMETRY;
+      process.env.SFCC_TELEMETRY = 'false';
+
+      try {
+        // Create command instance
+        const command = new MockedMcpServerCommand.default([], {
+          name: 'test',
+          version: '1.0.0',
+          root: process.cwd(),
+        });
+
+        // Stub init to set up flags
+        sandbox.stub(command, 'init').resolves();
+        (command as unknown as {flags: Record<string, unknown>}).flags = {
+          'allow-non-ga-tools': false,
+          'log-level': 'silent',
+        };
+
+        // Stub resolvedConfig with required methods
+        sandbox.stub(command, 'resolvedConfig').get(() => ({
+          values: {},
+          hasMrtConfig: () => false,
+          hasB2CInstanceConfig: () => false,
+          hasOAuth: () => false,
+          hasBasicAuth: () => false,
+        }));
+
+        // Stub logger
+        sandbox.stub(command, 'logger').get(() => ({info: sandbox.stub()}));
+
+        // Run the command
+        await command.run();
+
+        // Verify createTelemetry was NOT called
+        expect(createTelemetryStub.called).to.be.false;
+      } finally {
+        // Restore env
+        if (originalEnv === undefined) {
+          delete process.env.SFCC_TELEMETRY;
+        } else {
+          process.env.SFCC_TELEMETRY = originalEnv;
+        }
+      }
+    });
+  });
 });