Remove load sync channel (#4466)

Author: h-mayorquin

src/spikeinterface/extractors/neoextractors/openephys.py

@@ -130,10 +130,6 @@ class OpenEphysBinaryRecordingExtractor(NeoBaseRecordingExtractor):
         Alternative way to specify which experiment to load using a zero-based index.
         block_index=0 corresponds to experiment1, block_index=1 to experiment2, etc.
         Cannot be used together with experiment_name.
-    load_sync_channel : bool, default: False
-        **DEPRECATED: Use stream_name or stream_id to load sync streams. Will be removed in version 0.104.0**
-        If False (default) and a SYNC channel is present (e.g., Neuropixels), this is not loaded.
-        If True, the SYNC channel is loaded and can be accessed in the analog signals.
     load_sync_timestamps : bool, default: False
         If True, the synchronized_timestamps are loaded and set as times to the recording.
         If False (default), only the t_start and sampling rate are set, and timestamps are assumed
@@ -224,7 +220,6 @@ def __init__(
         stream_id: str = None,
         stream_name: str = None,
         block_index: int = None,
-        load_sync_channel: bool = False,
         load_sync_timestamps: bool = False,
         experiment_names: str | list | None = None,
         all_annotations: bool = False,
@@ -275,16 +270,9 @@ def __init__(
             # Single experiment: no filtering needed, let base class handle it
             block_index = None
 
-        if load_sync_channel:
-            warning_message = (
-                "OpenEphysBinaryRecordingExtractor: `load_sync_channel` is deprecated and will "
-                "be removed in version 0.104, use the `stream_name` or `stream_id` to load the sync stream if needed"
-            )
-            warnings.warn(warning_message, DeprecationWarning, stacklevel=2)
-
         stream_is_not_specified = stream_name is None and stream_id is None
         if stream_is_not_specified:
-            available_stream_names, _ = self.get_streams(folder_path, load_sync_channel, experiment_names_for_neo)
+            available_stream_names, _ = self.get_streams(folder_path, experiment_names_for_neo)
 
             # Auto-select neural data stream when there are exactly two streams (neural + sync)
             # and no stream was explicitly specified
@@ -294,7 +282,7 @@ def __init__(
                     neural_stream_name = next(stream for stream in available_stream_names if "SYNC" not in stream)
                     stream_name = neural_stream_name
 
-        neo_kwargs = self.map_to_neo_kwargs(folder_path, load_sync_channel, experiment_names_for_neo)
+        neo_kwargs = self.map_to_neo_kwargs(folder_path, experiment_names_for_neo)
         NeoBaseRecordingExtractor.__init__(
             self,
             stream_id=stream_id,
@@ -307,7 +295,7 @@ def __init__(
         stream_is_sync = "SYNC" in self.stream_name
         if not stream_is_sync:
             # get streams to find correct probe
-            stream_names, stream_ids = self.get_streams(folder_path, load_sync_channel, experiment_names_for_neo)
+            stream_names, stream_ids = self.get_streams(folder_path, experiment_names_for_neo)
             if stream_name is None and stream_id is None:
                 stream_name = stream_names[0]
             elif stream_name is None:
@@ -327,8 +315,8 @@ def __init__(
                 exp_id = exp_ids[block_index]
             rec_ids = sorted(list(node_structure["experiments"][exp_id]["recordings"].keys()))
 
-            # do not load probe for NIDQ stream or if load_sync_channel is True
-            if "NI-DAQmx" not in stream_name and not load_sync_channel:
+            # do not load probe for NIDQ stream
+            if "NI-DAQmx" not in stream_name:
                 settings_file = node_structure["experiments"][exp_id]["settings_file"]
 
                 if Path(settings_file).is_file():
@@ -377,16 +365,14 @@ def __init__(
             dict(
                 folder_path=str(Path(folder_path).absolute()),
                 experiment_name=experiment_name,
-                load_sync_channel=load_sync_channel,
                 load_sync_timestamps=load_sync_timestamps,
             )
         )
 
     @classmethod
-    def map_to_neo_kwargs(cls, folder_path, load_sync_channel=False, experiment_names=None):
+    def map_to_neo_kwargs(cls, folder_path, experiment_names=None):
         neo_kwargs = {
             "dirname": str(folder_path),
-            "load_sync_channel": load_sync_channel,
             "experiment_names": experiment_names,
         }
         return neo_kwargs
@@ -502,11 +488,6 @@ def read_openephys(folder_path, **kwargs):
         Cannot be used together with experiment_name.
     all_annotations : bool, default: False
         Load exhaustively all annotation from neo
-    load_sync_channel : bool, default: False
-        **DEPRECATED: Use stream_name or stream_id to load sync streams**
-        If False (default) and a SYNC channel is present (e.g. Neuropixels), this is not loaded.
-        If True, the SYNC channel is loaded and can be accessed in the analog signals.
-        For open ephys binary format only
     load_sync_timestamps : bool, default: False
         If True, the synchronized_timestamps are loaded and set as times to the recording.
         If False (default), only the t_start and sampling rate are set, and timestamps are assumed