adapted clang-tidy integration

Author: StephanKa

.clang-tidy

@@ -1,18 +1,97 @@
 ---
-Checks: "*,
-        -abseil-*,
-        -altera-*,
-        -android-*,
-        -fuchsia-*,
-        -google-*,
-        -llvm*,
-        -modernize-use-trailing-return-type,
-        -zircon-*,
-        -readability-else-after-return,
-        -readability-static-accessed-through-instance,
-        -readability-avoid-const-params-in-decls,
-        -cppcoreguidelines-non-private-member-variables-in-classes,
-        -misc-non-private-member-variables-in-classes,
-"
-HeaderFilterRegex: ''
-FormatStyle:     none
+# Enable a curated set of check families relevant to a modern C++20 project.
+# Platform/framework-specific groups (abseil, altera, android, fuchsia,
+# google, llvm, zircon) are excluded entirely.
+Checks: >
+  bugprone-*,
+  cert-*,
+  clang-analyzer-*,
+  concurrency-*,
+  cppcoreguidelines-*,
+  misc-*,
+  modernize-*,
+  performance-*,
+  portability-*,
+  readability-*,
+  -abseil-*,
+  -altera-*,
+  -android-*,
+  -fuchsia-*,
+  -google-*,
+  -llvm-*,
+  -llvmlibc-*,
+  -zircon-*,
+  -hicpp-*,
+  -modernize-use-trailing-return-type,
+  -readability-else-after-return,
+  -readability-static-accessed-through-instance,
+  -readability-avoid-const-params-in-decls,
+  -cppcoreguidelines-non-private-member-variables-in-classes,
+  -misc-non-private-member-variables-in-classes,
+  -readability-magic-numbers,
+  -cppcoreguidelines-avoid-magic-numbers,
+  -cert-err58-cpp,
+  -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
+  -cppcoreguidelines-pro-type-vararg,
+  -misc-include-cleaner,
+
+# Only analyse headers that belong to this project; ignore installed/conan deps.
+HeaderFilterRegex: '(src|test|fuzz_test)/.*'
+
+# Treat every clang-tidy warning as an error (mirrors WARNINGS_AS_ERRORS).
+WarningsAsErrors: '*'
+
+# Pick up the project .clang-format when applying fixes.
+FormatStyle: file
+
+CheckOptions:
+  # ---------- naming conventions (mirrors the project style) ----------
+  - key: readability-identifier-naming.ClassCase
+    value: CamelCase
+  - key: readability-identifier-naming.StructCase
+    value: CamelCase
+  - key: readability-identifier-naming.EnumCase
+    value: CamelCase
+  - key: readability-identifier-naming.EnumConstantCase
+    value: CamelCase
+  - key: readability-identifier-naming.FunctionCase
+    value: camelBack
+  - key: readability-identifier-naming.MethodCase
+    value: camelBack
+  - key: readability-identifier-naming.MemberCase
+    value: camelBack
+  - key: readability-identifier-naming.PrivateMemberCase
+    value: camelBack
+  - key: readability-identifier-naming.PrivateMemberPrefix
+    value: 'm_'
+  - key: readability-identifier-naming.ParameterCase
+    value: camelBack
+  - key: readability-identifier-naming.LocalVariableCase
+    value: camelBack
+  - key: readability-identifier-naming.VariableCase
+    value: camelBack
+  - key: readability-identifier-naming.GlobalConstantCase
+    value: UPPER_CASE
+  - key: readability-identifier-naming.ConstexprVariableCase
+    value: UPPER_CASE
+  - key: readability-identifier-naming.NamespaceCase
+    value: lower_case
+  - key: readability-identifier-naming.TypeAliasCase
+    value: CamelCase
+  # ---------- thresholds ----------
+  - key: readability-function-cognitive-complexity.Threshold
+    value: '30'
+  - key: readability-function-size.LineThreshold
+    value: '80'
+  - key: readability-function-size.StatementThreshold
+    value: '50'
+  - key: bugprone-easily-swappable-parameters.MinimumLength
+    value: '3'
+  - key: cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor
+    value: 'true'
+  - key: cppcoreguidelines-special-member-functions.AllowMissingMoveFunctionsWhenCopyIsDeleted
+    value: 'true'
+  - key: modernize-use-default-member-init.UseAssignment
+    value: 'false'
+  - key: performance-unnecessary-value-param.AllowedTypes
+    value: ''

cmake/StaticAnalyzers.cmake

@@ -15,10 +15,18 @@ ENDIF()
 IF(ENABLE_CLANG_TIDY)
     FIND_PROGRAM(CLANG_TIDY_BINARY clang-tidy)
     IF(CLANG_TIDY_BINARY)
-        SET(CMAKE_CXX_CLANG_TIDY
+        SET(_clang_tidy_args
             ${CLANG_TIDY_BINARY}
+            --config-file=${CMAKE_SOURCE_DIR}/.clang-tidy
+            --header-filter=${CMAKE_SOURCE_DIR}/(src|test|fuzz_test)/.*
             -extra-arg=-Wno-unknown-warning-option
-            -p=${CMAKE_BINARY_DIR})
+            -p=${CMAKE_BINARY_DIR}
+        )
+        IF(WARNINGS_AS_ERRORS)
+            LIST(APPEND _clang_tidy_args --warnings-as-errors=*)
+        ENDIF()
+        SET(CMAKE_CXX_CLANG_TIDY ${_clang_tidy_args})
+        MESSAGE(STATUS "clang-tidy enabled: ${CLANG_TIDY_BINARY}")
     ELSE()
         MESSAGE(SEND_ERROR "clang-tidy requested but executable not found")
     ENDIF()