refactor: standardize success/error fields on all protocol Response types

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: Swofty

commons/src/main/java/net/swofty/commons/protocol/objects/api/APIAuthenticateCodeProtocolObject.java

@@ -3,6 +3,7 @@
 import net.swofty.commons.protocol.JacksonSerializer;
 import net.swofty.commons.protocol.ProtocolObject;
 import net.swofty.commons.protocol.Serializer;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.UUID;
 
@@ -21,5 +22,5 @@ public Serializer<AuthenticateCodeResponse> getReturnSerializer() {
 
     public record AuthenticateCodeMessage(String authCode, String playerName, UUID playerUUID) {}
 
-    public record AuthenticateCodeResponse(boolean successful) {}
+    public record AuthenticateCodeResponse(boolean success, @Nullable String error) {}
 }

commons/src/main/java/net/swofty/commons/protocol/objects/auctions/AuctionAddItemProtocolObject.java

@@ -7,6 +7,7 @@
 import net.swofty.commons.protocol.Serializer;
 
 import java.util.UUID;
+import org.jetbrains.annotations.Nullable;
 
 public class AuctionAddItemProtocolObject extends ProtocolObject
         <AuctionAddItemProtocolObject.AuctionAddItemMessage,
@@ -24,5 +25,5 @@ public Serializer<AuctionAddItemResponse> getReturnSerializer() {
 
     public record AuctionAddItemMessage(AuctionItem item, AuctionCategories category) {}
 
-    public record AuctionAddItemResponse(UUID uuid) {}
+    public record AuctionAddItemResponse(UUID uuid, boolean success, @Nullable String error) {}
 }

commons/src/main/java/net/swofty/commons/protocol/objects/auctions/AuctionFetchItemProtocolObject.java

@@ -6,6 +6,7 @@
 import net.swofty.commons.protocol.Serializer;
 
 import java.util.UUID;
+import org.jetbrains.annotations.Nullable;
 
 public class AuctionFetchItemProtocolObject extends ProtocolObject<
         AuctionFetchItemProtocolObject.AuctionFetchItemMessage,
@@ -23,5 +24,5 @@ public Serializer<AuctionFetchItemResponse> getReturnSerializer() {
 
     public record AuctionFetchItemMessage(UUID uuid) {}
 
-    public record AuctionFetchItemResponse(AuctionItem item) {}
+    public record AuctionFetchItemResponse(AuctionItem item, boolean success, @Nullable String error) {}
 }

commons/src/main/java/net/swofty/commons/protocol/objects/auctions/AuctionFetchItemsProtocolObject.java

@@ -9,6 +9,7 @@
 import net.swofty.commons.skyblock.auctions.AuctionItem;
 
 import java.util.List;
+import org.jetbrains.annotations.Nullable;
 
 public class AuctionFetchItemsProtocolObject extends ProtocolObject<
         AuctionFetchItemsProtocolObject.AuctionFetchItemsMessage,
@@ -31,6 +32,8 @@ public record AuctionFetchItemsMessage(
     ) {}
 
     public record AuctionFetchItemsResponse(
-            List<AuctionItem> items
+            List<AuctionItem> items,
+            boolean success,
+            @Nullable String error
     ) {}
 }

commons/src/main/java/net/swofty/commons/protocol/objects/bazaar/BazaarBuyProtocolObject.java

@@ -3,6 +3,7 @@
 import net.swofty.commons.protocol.JacksonSerializer;
 import net.swofty.commons.protocol.ProtocolObject;
 import net.swofty.commons.protocol.Serializer;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.UUID;
 
@@ -21,5 +22,5 @@ public Serializer<BazaarBuyResponse> getReturnSerializer() {
 
     public record BazaarBuyMessage(String itemName, int amount, double price, UUID playerUUID, UUID profileUUID) {}
 
-    public record BazaarBuyResponse(boolean successful) {}
+    public record BazaarBuyResponse(boolean success, @Nullable String error) {}
 }

commons/src/main/java/net/swofty/commons/protocol/objects/bazaar/BazaarCancelProtocolObject.java

@@ -3,6 +3,7 @@
 import net.swofty.commons.protocol.JacksonSerializer;
 import net.swofty.commons.protocol.ProtocolObject;
 import net.swofty.commons.protocol.Serializer;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.UUID;
 
@@ -22,5 +23,5 @@ public Serializer<CancelResponse> getReturnSerializer() {
 
     public record CancelMessage(UUID orderId, UUID playerUuid, UUID profileUuid) {}
 
-    public record CancelResponse(boolean successful) {}
+    public record CancelResponse(boolean success, @Nullable String error) {}
 }

commons/src/main/java/net/swofty/commons/protocol/objects/bazaar/BazaarGetItemProtocolObject.java

@@ -6,6 +6,7 @@
 
 import java.util.List;
 import java.util.UUID;
+import org.jetbrains.annotations.Nullable;
 
 public class BazaarGetItemProtocolObject extends ProtocolObject<
         BazaarGetItemProtocolObject.BazaarGetItemMessage,
@@ -26,7 +27,9 @@ public record BazaarGetItemMessage(String itemName) {}
     public record BazaarGetItemResponse(
             String itemName,
             List<OrderRecord> buyOrders,
-            List<OrderRecord> sellOrders
+            List<OrderRecord> sellOrders,
+            boolean success,
+            @Nullable String error
     ) {}
 
     public record OrderRecord(

commons/src/main/java/net/swofty/commons/protocol/objects/bazaar/BazaarGetPendingOrdersProtocolObject.java

@@ -6,6 +6,7 @@
 
 import java.util.List;
 import java.util.UUID;
+import org.jetbrains.annotations.Nullable;
 
 public class BazaarGetPendingOrdersProtocolObject
         extends ProtocolObject<
@@ -33,5 +34,5 @@ public record PendingOrder(
             UUID profileUUID
     ) {}
 
-    public record BazaarGetPendingOrdersResponse(List<PendingOrder> orders) {}
+    public record BazaarGetPendingOrdersResponse(List<PendingOrder> orders, boolean success, @Nullable String error) {}
 }

commons/src/main/java/net/swofty/commons/protocol/objects/bazaar/BazaarGetPendingTransactionsProtocolObject.java

@@ -8,6 +8,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.UUID;
+import org.jetbrains.annotations.Nullable;
 
 public class BazaarGetPendingTransactionsProtocolObject extends ProtocolObject<
         BazaarGetPendingTransactionsProtocolObject.BazaarGetPendingTransactionsMessage,
@@ -25,7 +26,7 @@ public Serializer<BazaarGetPendingTransactionsResponse> getReturnSerializer() {
 
     public record BazaarGetPendingTransactionsMessage(UUID playerUUID, UUID profileUUID) {}
 
-    public record BazaarGetPendingTransactionsResponse(List<PendingTransactionInfo> transactions) {}
+    public record BazaarGetPendingTransactionsResponse(List<PendingTransactionInfo> transactions, boolean success, @Nullable String error) {}
 
     public record PendingTransactionInfo(
             String id,

commons/src/main/java/net/swofty/commons/protocol/objects/bazaar/BazaarProcessPendingTransactionsProtocolObject.java

@@ -6,6 +6,7 @@
 
 import java.util.List;
 import java.util.UUID;
+import org.jetbrains.annotations.Nullable;
 
 public class BazaarProcessPendingTransactionsProtocolObject extends ProtocolObject<
         BazaarProcessPendingTransactionsProtocolObject.BazaarProcessPendingTransactionsMessage,
@@ -23,5 +24,5 @@ public Serializer<BazaarProcessPendingTransactionsResponse> getReturnSerializer(
 
     public record BazaarProcessPendingTransactionsMessage(UUID playerUUID, UUID profileUUID, List<String> transactionIds) {}
 
-    public record BazaarProcessPendingTransactionsResponse(int processedCount, int failedCount, List<String> successfulTransactionIds, List<String> failedTransactionIds) {}
+    public record BazaarProcessPendingTransactionsResponse(int processedCount, int failedCount, List<String> successfulTransactionIds, List<String> failedTransactionIds, boolean success, @Nullable String error) {}
 }