refactor(i18n): migrate 8 hub NPCs to use DialogueSet.ofTranslation()

Replace hardcoded dialogue strings with translation key references
in NPCBaker, NPCBanker, NPCArthur, NPCBartender, NPCAlchemist,
NPCAdventurer, NPCAuctionMaster, and NPCFarmerRigby.

Author: Swofty-Developments

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCAdventurer.java

@@ -5,6 +5,7 @@
 import net.swofty.type.generic.entity.npc.HypixelNPC;
 import net.swofty.type.generic.entity.npc.configuration.HumanConfiguration;
 import net.swofty.type.generic.event.custom.NPCInteractEvent;
+import net.swofty.type.generic.i18n.I18n;
 import net.swofty.type.generic.user.HypixelPlayer;
 import net.swofty.type.hub.gui.GUIShopAdventurer;
 
@@ -57,13 +58,7 @@ public void onClick(NPCInteractEvent e) {
     @Override
     public DialogueSet[] dialogues(HypixelPlayer player) {
         return new DialogueSet[] {
-                DialogueSet.builder()
-                        .key("hello").lines(new String[]{
-                                "I've seen it all - every island from here to the edge of the world!",
-                                "Over the years I've acquired a variety of Talismans and Artifact.",
-                                "For a price, you can have it all!",
-                                "Click me again to open the Adventurer Shop!"
-                        }).build(),
+                DialogueSet.ofTranslation("hello", "npcs_hub.adventurer.dialogue.hello")
         };
     }
 }

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCAlchemist.java

@@ -6,10 +6,13 @@
 import net.swofty.type.generic.entity.npc.HypixelNPC;
 import net.swofty.type.generic.entity.npc.configuration.AnimalConfiguration;
 import net.swofty.type.generic.event.custom.NPCInteractEvent;
+import net.swofty.type.generic.i18n.I18n;
 import net.swofty.type.generic.user.HypixelPlayer;
 import net.swofty.type.hub.gui.GUIShopAlchemist;
 import net.swofty.type.skyblockgeneric.user.SkyBlockPlayer;
 
+import java.util.Map;
+
 public class NPCAlchemist extends HypixelNPC {
     public NPCAlchemist() {
         super(new AnimalConfiguration() {
@@ -60,12 +63,7 @@ public void onClick(NPCInteractEvent e) {
     @Override
     public DialogueSet[] dialogues(HypixelPlayer player) {
         return new DialogueSet[] {
-                DialogueSet.builder()
-                        .key("hello").lines(new String[]{
-                                "There is a darkness in you, " + player.getUsername() + ".",
-                                "I've seen it in my flames, you are destined for great things.",
-                                "For now, you shouldn't let it get to your head."
-                        }).build(),
+                DialogueSet.ofTranslation("hello", "npcs_hub.alchemist.dialogue.hello", Map.of("player", player.getUsername()))
         };
     }
 }

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCArthur.java

@@ -4,6 +4,7 @@
 import net.swofty.type.generic.entity.npc.HypixelNPC;
 import net.swofty.type.generic.entity.npc.configuration.HumanConfiguration;
 import net.swofty.type.generic.event.custom.NPCInteractEvent;
+import net.swofty.type.generic.i18n.I18n;
 import net.swofty.type.generic.user.HypixelPlayer;
 
 import java.util.stream.Stream;
@@ -48,38 +49,14 @@ public void onClick(NPCInteractEvent e) {
 
     @Override
     public DialogueSet[] dialogues(HypixelPlayer player) {
-        return Stream.of(
-                DialogueSet.builder()
-                        .key("dialogue-1").lines(new String[]{
-                                "Fuel makes your Minion work harder for a limited time",
-                                "There are multiple types of Fuel, like Coal, Enchanted Bread and many more!"
-                        }).build(),
-                DialogueSet.builder()
-                        .key("dialogue-2").lines(new String[]{
-                                "If you place your Minions poorly, they will complain!",
-                                "Open their Menu and look for their Perfect Layout!"
-                        }).build(),
-                DialogueSet.builder()
-                        .key("dialogue-3").lines(new String[]{
-                                "Once you unlock a Minion, you also unlock all their Level up recipes!"
-                        }).build(),
-                DialogueSet.builder()
-                        .key("dialogue-4").lines(new String[]{
-                                "Use a §aBudget Hopper§f to make your Minions automatically sell their work once full!"
-                        }).build(),
-                DialogueSet.builder()
-                        .key("dialogue-5").lines(new String[]{
-                                "My favorite Minion Upgrade is the §aCompactor§f, sooooo useful!",
-                                "I have one in my Minion, look!"
-                        }).build(),
-                DialogueSet.builder()
-                        .key("dialogue-6").lines(new String[]{
-                                "People always empty the storage of my Minion when I'm not looking!"
-                        }).build(),
-                DialogueSet.builder()
-                        .key("dialogue-7").lines(new String[]{
-                                "Minions always have 4 Upgrade Slots where you can place Fuel or else"
-                        }).build()
-        ).toArray(DialogueSet[]::new);
+        return new DialogueSet[] {
+                DialogueSet.ofTranslation("dialogue-1", "npcs_hub.arthur.dialogue.dialogue_1"),
+                DialogueSet.ofTranslation("dialogue-2", "npcs_hub.arthur.dialogue.dialogue_2"),
+                DialogueSet.ofTranslation("dialogue-3", "npcs_hub.arthur.dialogue.dialogue_3"),
+                DialogueSet.ofTranslation("dialogue-4", "npcs_hub.arthur.dialogue.dialogue_4"),
+                DialogueSet.ofTranslation("dialogue-5", "npcs_hub.arthur.dialogue.dialogue_5"),
+                DialogueSet.ofTranslation("dialogue-6", "npcs_hub.arthur.dialogue.dialogue_6"),
+                DialogueSet.ofTranslation("dialogue-7", "npcs_hub.arthur.dialogue.dialogue_7")
+        };
     }
 }

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCAuctionMaster.java

@@ -4,6 +4,7 @@
 import net.swofty.type.generic.entity.npc.HypixelNPC;
 import net.swofty.type.generic.entity.npc.configuration.HumanConfiguration;
 import net.swofty.type.generic.event.custom.NPCInteractEvent;
+import net.swofty.type.generic.i18n.I18n;
 import net.swofty.type.generic.user.HypixelPlayer;
 import net.swofty.type.skyblockgeneric.gui.inventories.auction.GUIAuctionHouse;
 import net.swofty.type.skyblockgeneric.mission.MissionData;
@@ -44,15 +45,9 @@ public boolean looking(HypixelPlayer player) {
 
     @Override
     public DialogueSet[] dialogues(HypixelPlayer player) {
-        return Stream.of(
-                DialogueSet.builder()
-                        .key("quest-hello").lines(new String[]{
-                                "Hey there, I'm the Auction Master.",
-                                "In the §6Auction House§f, you can put your valuable items up for auction!",
-                                "You may also want to check back here to see what items other players are selling to see if you can get a good deal.",
-                                "Talk to me or one of the §6Auction Agents §fif you would like to start your first auction or if you want to see the items currently being sold."
-                        }).build()
-        ).toArray(DialogueSet[]::new);
+        return new DialogueSet[] {
+                DialogueSet.ofTranslation("quest-hello", "npcs_hub.auction_master.dialogue.quest_hello")
+        };
     }
 
     @Override

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCBaker.java

@@ -15,6 +15,8 @@
 import net.swofty.type.skyblockgeneric.item.SkyBlockItem;
 import net.swofty.type.skyblockgeneric.user.SkyBlockPlayer;
 
+import net.swofty.type.generic.i18n.I18n;
+
 import java.util.List;
 import java.util.stream.Stream;
 
@@ -87,13 +89,8 @@ public void onClick(NPCInteractEvent event) {
 
     @Override
     protected DialogueSet[] dialogues(HypixelPlayer player) {
-        return Stream.of(
-                DialogueSet.builder()
-                        .key("initial-hello").lines(new String[]{
-                                "At the end of each year I bake cakes for everyone in town to celebrate the year.",
-                                "I made one especially for you, here you go.",
-                                "I've recently added a §dNew Year Cake Bag §fto my inventory. Sadly, it's not free! Click me again to open my shop!",
-                        }).build()
-        ).toArray(DialogueSet[]::new);
+        return new DialogueSet[] {
+                DialogueSet.ofTranslation("initial-hello", "npcs_hub.baker.dialogue.initial_hello")
+        };
     }
 }

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCBanker.java

@@ -4,6 +4,7 @@
 import net.swofty.type.generic.entity.npc.HypixelNPC;
 import net.swofty.type.generic.entity.npc.configuration.HumanConfiguration;
 import net.swofty.type.generic.event.custom.NPCInteractEvent;
+import net.swofty.type.generic.i18n.I18n;
 import net.swofty.type.generic.user.HypixelPlayer;
 import net.swofty.type.skyblockgeneric.gui.inventories.banker.GUIBanker;
 import net.swofty.type.skyblockgeneric.mission.MissionData;
@@ -58,13 +59,8 @@ public void onClick(NPCInteractEvent e) {
 
     @Override
     public DialogueSet[] dialogues(HypixelPlayer player) {
-        return Stream.of(
-                DialogueSet.builder()
-                        .key("quest-hello").lines(new String[]{
-                                "Hello there!",
-                                "You may want to store your §6Coins §fin a safe place while you are off adventuring.",
-                                "Storing them in your §6Bank §fkeeps them safe and allows you to earn interest at the start of every season!"
-                        }).build()
-        ).toArray(DialogueSet[]::new);
+        return new DialogueSet[] {
+                DialogueSet.ofTranslation("quest-hello", "npcs_hub.banker.dialogue.quest_hello")
+        };
     }
 }

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCBartender.java

@@ -4,6 +4,7 @@
 import net.swofty.type.generic.entity.npc.HypixelNPC;
 import net.swofty.type.generic.entity.npc.configuration.HumanConfiguration;
 import net.swofty.type.generic.event.custom.NPCInteractEvent;
+import net.swofty.type.generic.i18n.I18n;
 import net.swofty.type.generic.user.HypixelPlayer;
 import net.swofty.type.hub.gui.GUIShopBartender;
 import net.swofty.type.skyblockgeneric.mission.missions.MissionKillZombies;
@@ -68,24 +69,10 @@ public void onClick(NPCInteractEvent e) {
 
     @Override
     public DialogueSet[] dialogues(HypixelPlayer player) {
-        return Stream.of(
-                DialogueSet.builder()
-                        .key("quest-hello").lines(new String[]{
-                                "Welcome to the Bar, friend!",
-                                "These are trying times, indeed. The §cGraveyard §fis overflowing with monsters! Anyone who comes in is spooked off by the grunts of zombies in the distance.",
-                                "Could you give me a hand? If you help clear out some of these monsters, I'll pay you for it."
-                        }).build(),
-                DialogueSet.builder()
-                        .key("quest-talk").lines(new String[]{
-                                "Clear out some more of those Zombies and I'll pay you greatly for it!"
-                        }).build(),
-                DialogueSet.builder()
-                        .key("quest-complete").lines(new String[]{
-                                "Words cannot describe how thankful I am!",
-                                "That whole area is very dangerous, but can be quite rewarding for a warrior such as yourself.",
-                                "If you're up for the challenge, both the §cGraveyard§f and the §cSpider's Den §fbeyond it are great training grounds for improving your §aCombat Skill§f.",
-                                "For now, here's a reward for helping me out!"
-                        }).build()
-        ).toArray(DialogueSet[]::new);
+        return new DialogueSet[] {
+                DialogueSet.ofTranslation("quest-hello", "npcs_hub.bartender.dialogue.quest_hello"),
+                DialogueSet.ofTranslation("quest-talk", "npcs_hub.bartender.dialogue.quest_talk"),
+                DialogueSet.ofTranslation("quest-complete", "npcs_hub.bartender.dialogue.quest_complete")
+        };
     }
 }

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCFarmerRigby.java

@@ -4,6 +4,7 @@
 import net.swofty.type.generic.entity.npc.HypixelNPC;
 import net.swofty.type.generic.entity.npc.configuration.HumanConfiguration;
 import net.swofty.type.generic.event.custom.NPCInteractEvent;
+import net.swofty.type.generic.i18n.I18n;
 import net.swofty.type.generic.user.HypixelPlayer;
 import net.swofty.type.skyblockgeneric.mission.MissionData;
 import net.swofty.type.skyblockgeneric.mission.missions.farmer.MissionCollectWheat;
@@ -70,19 +71,10 @@ public void onClick(NPCInteractEvent e) {
 
     @Override
     public DialogueSet[] dialogues(HypixelPlayer player) {
-        return List.of(
-                DialogueSet.builder()
-                        .key("initial-hello").lines(new String[]{
-                                "Howdy, friend!",
-                                "My cow is sick, she needs some food to replenish her strength.",
-                                "Could you gather some Wheat from my farm and bring it back to me so that I can feed her? Poor thing."
-                        }).build(),
-                DialogueSet.builder()
-                        .key("spoke-again").lines(new String[]{
-                                "Thank you so much!",
-                                "My Farm is yours to harvest! Wheat is a valuable resource to collect, you can unlock many cool things by collecting it."
-                        }).build()
-        ).stream().toArray(DialogueSet[]::new);
+        return new DialogueSet[] {
+                DialogueSet.ofTranslation("initial-hello", "npcs_hub.farmer_rigby.dialogue.initial_hello"),
+                DialogueSet.ofTranslation("spoke-again", "npcs_hub.farmer_rigby.dialogue.spoke_again")
+        };
     }
 
 }