fix(punishment): fix runtime bugs in punishment system

Add no-arg constructor to PunishmentReason for Gson deserialization,
fix "muted for muted for" typo, replace jedis.keys() with SCAN, make
getAllBannedPlayerIds synchronous so UnBanCommand suggestions populate,
use SecureRandom for PunishmentId generation, fix permanent ban expiry
validation in PunishPlayerEndpoint.

Author: Swofty-Developments

commons/src/main/java/net/swofty/commons/punishment/PunishmentId.java

@@ -1,13 +1,15 @@
 package net.swofty.commons.punishment;
 
+import java.security.SecureRandom;
+
 public record PunishmentId(String id) {
+    private static final SecureRandom RANDOM = new SecureRandom();
 
     public static PunishmentId generateId() {
         StringBuilder idBuilder = new StringBuilder("#");
         String hexChars = "0123456789ABCDEF";
         for (int i = 0; i < 8; i++) {
-            int randomIndex = (int) (Math.random() * hexChars.length());
-            idBuilder.append(hexChars.charAt(randomIndex));
+            idBuilder.append(hexChars.charAt(RANDOM.nextInt(hexChars.length())));
         }
         return new PunishmentId(idBuilder.toString());
     }

commons/src/main/java/net/swofty/commons/punishment/PunishmentReason.java

@@ -1,13 +1,14 @@
 package net.swofty.commons.punishment;
 
 import lombok.Getter;
+import lombok.NoArgsConstructor;
 import lombok.NonNull;
 import net.swofty.commons.punishment.template.BanType;
 import net.swofty.commons.punishment.template.MuteType;
-import net.swofty.commons.punishment.template.UnpunishReason;
 import org.jetbrains.annotations.Nullable;
 
 @Getter
+@NoArgsConstructor
 public class PunishmentReason {
     @Nullable
     private BanType banType;

commons/src/main/java/net/swofty/commons/punishment/PunishmentRedis.java

@@ -15,7 +15,6 @@
 import java.util.Set;
 import java.util.UUID;
 import java.util.concurrent.CompletableFuture;
-import java.util.stream.Collectors;
 
 public class PunishmentRedis {
     private static final String PREFIX = "punish:";
@@ -158,7 +157,7 @@ public static Component parseActivePunishmentMuteMessage(ActivePunishment punish
         if (expiresAt <= 0) {
             header = "§cYou are permanently muted on this server!\n";
         } else {
-            header = "§cYou are currently muted for muted for " + reason.getReasonString() + "\n";
+            header = "§cYou are currently muted for " + reason.getReasonString() + "\n";
         }
         String time = "§7Your mute will expire in §c" + prettyTimeLeft + "\n\n";
 
@@ -167,16 +166,20 @@ public static Component parseActivePunishmentMuteMessage(ActivePunishment punish
         return Component.text(line + header + time + urlInfo + footer + line);
     }
 
-    // lookup for all BANNED players
-    public static CompletableFuture<Set<String>> getAllBannedPlayerIds() {
-        return CompletableFuture.supplyAsync(() -> {
-            try (Jedis jedis = jedisPool.getResource()) {
-                Set<String> keys = jedis.keys(PREFIX + "active:*");
-                return keys.stream()
-                        .map(key -> key.substring((PREFIX + "active:").length()))
-                        .collect(Collectors.toSet());
-            }
-        });
+    public static Set<String> getAllBannedPlayerIds() {
+        try (Jedis jedis = jedisPool.getResource()) {
+            var cursor = "0";
+            Set<String> result = new java.util.HashSet<>();
+            var params = new redis.clients.jedis.params.ScanParams().match(PREFIX + "active:*").count(100);
+            do {
+                var scanResult = jedis.scan(cursor, params);
+                for (String key : scanResult.getResult()) {
+                    result.add(key.substring((PREFIX + "active:").length()));
+                }
+                cursor = scanResult.getCursor();
+            } while (!"0".equals(cursor));
+            return result;
+        }
     }
 
 }

service.punishment/src/main/java/net/swofty/service/punishment/endpoints/PunishPlayerEndpoint.java

@@ -36,8 +36,7 @@ public PunishPlayerProtocolObject.PunishPlayerResponse onMessage(ServiceProxyReq
         PunishmentId id = PunishmentId.generateId();
 
         Instant now = Instant.now();
-        Instant expiresAt = Instant.ofEpochMilli(messageObject.expiresAt());
-        if (expiresAt.isBefore(Instant.now())) {
+        if (messageObject.expiresAt() > 0 && Instant.ofEpochMilli(messageObject.expiresAt()).isBefore(now)) {
             return new PunishPlayerProtocolObject.PunishPlayerResponse(false, null, PunishPlayerProtocolObject.ErrorCode.INVALID_EXPIRY, "The expiration time provided is invalid.");
         }
 
@@ -62,7 +61,7 @@ public PunishPlayerProtocolObject.PunishPlayerResponse onMessage(ServiceProxyReq
                 messageObject.type(),
                 messageObject.target(),
                 reason.getReasonString(),
-                expiresAt.toString()
+                messageObject.expiresAt()
         );
         return new PunishPlayerProtocolObject.PunishPlayerResponse(true, id.id(), null, null);
     }

type.generic/src/main/java/net/swofty/type/generic/command/commands/UnBanCommand.java

@@ -1,7 +1,6 @@
 package net.swofty.type.generic.command.commands;
 
 import net.minestom.server.command.builder.arguments.Argument;
-import net.minestom.server.command.builder.arguments.ArgumentString;
 import net.minestom.server.command.builder.arguments.ArgumentType;
 import net.minestom.server.command.builder.suggestion.SuggestionEntry;
 import net.minestom.server.utils.mojang.MojangUtils;
@@ -11,6 +10,7 @@
 import net.swofty.type.generic.user.categories.Rank;
 
 import java.io.IOException;
+import java.util.Set;
 import java.util.UUID;
 
 @CommandParameters(
@@ -25,12 +25,11 @@ public class UnBanCommand extends HypixelCommand {
     @Override
     public void registerUsage(MinestomCommand command) {
         Argument<String> argument = ArgumentType.String("player").setSuggestionCallback((sender, context, suggestion) -> {
-            PunishmentRedis.getAllBannedPlayerIds().thenAccept((id) -> {
-                for (String playerName : id) {
-                    UUID playerUuid = UUID.fromString(playerName);
-                    suggestion.addEntry(new SuggestionEntry(playerUuid.toString()));
-                }
-            });
+            if (!PunishmentRedis.isInitialized()) return;
+            Set<String> ids = PunishmentRedis.getAllBannedPlayerIds();
+            for (String playerId : ids) {
+                suggestion.addEntry(new SuggestionEntry(playerId));
+            }
         });
 
         command.addSyntax((sender, context) -> {