feat: update NPC stuff

Author: ArikSquad

type.generic/src/main/java/net/swofty/type/generic/entity/npc/HypixelNPC.java

@@ -6,6 +6,7 @@
 import net.kyori.adventure.sound.Sound;
 import net.minestom.server.coordinate.Pos;
 import net.minestom.server.entity.Entity;
+import net.minestom.server.entity.GameMode;
 import net.swofty.type.generic.entity.npc.configuration.AnimalConfiguration;
 import net.swofty.type.generic.entity.npc.configuration.HumanConfiguration;
 import net.swofty.type.generic.entity.npc.configuration.NPCConfiguration;
@@ -153,7 +154,7 @@ public static void updateForPlayer(HypixelPlayer player) {
 
                 Pos playerPosition = player.getPosition();
                 double entityDistance = playerPosition.distance(npcPosition);
-                boolean isLookingNPC = config.looking(player);
+                boolean isLookingNPC = config.looking(player) && player.getGameMode() != GameMode.SPECTATOR;
 
                 // Get inRangeOf list based on entity type
                 List<HypixelPlayer> inRange = npcViewable.getInRangeOf();

type.generic/src/main/java/net/swofty/type/generic/entity/npc/configuration/NPCConfiguration.java

@@ -33,4 +33,8 @@ default Instance instance() {
     default EntityPose pose(HypixelPlayer player) {
         return EntityPose.STANDING;
     }
+
+    default boolean shouldDisplayHolograms(HypixelPlayer player) {
+        return true;
+    }
 }

type.generic/src/main/java/net/swofty/type/generic/entity/npc/impl/NPCEntityImpl.java

@@ -65,7 +65,9 @@ public NPCEntityImpl(@NotNull HypixelPlayer viewer, @NotNull Pos pos, @NotNull S
             .build();
 
         this.holo = holo;
-        PlayerHolograms.addExternalPlayerHologram(holo);
+        if (config.shouldDisplayHolograms(viewer)) {
+            PlayerHolograms.addExternalPlayerHologram(holo);
+        }
 
         setInstance(config.instance(), pos);
         addViewer(viewer);
@@ -122,7 +124,7 @@ public void tick(long time) {
     @Override
     public void updateNPC() {
         Pos npcPosition = config.position(viewer);
-        if (!getPosition().asVec().equals(npcPosition.asVec())) {
+        if (!getPosition().asVec().equals(npcPosition.asVec()) && config.shouldDisplayHolograms(viewer)) {
             PlayerHolograms.relocateExternalPlayerHologram(holo, npcPosition.add(0, getEyeHeight() + 0.1f, 0));
         }
 
@@ -137,10 +139,14 @@ public void updateNPC() {
             ));
         }
 
-        String[] newHolograms = config.holograms(viewer);
-        if (!Arrays.equals(newHolograms, holograms)) {
-            PlayerHolograms.updateExternalPlayerHologramText(holo, newHolograms);
-            this.holograms = newHolograms;
+        if (config.shouldDisplayHolograms(viewer)) {
+            String[] newHolograms = config.holograms(viewer);
+            if (!Arrays.equals(newHolograms, holograms)) {
+                PlayerHolograms.updateExternalPlayerHologramText(holo, newHolograms);
+                this.holograms = newHolograms;
+            }
+        } else {
+            PlayerHolograms.removeExternalPlayerHologram(holo);
         }
 
         String actualSkinTexture = config.texture(viewer);

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCDanteMemorial.java

@@ -31,8 +31,8 @@ public Pos position(HypixelPlayer player) {
             }
 
             @Override
-            public boolean looking(HypixelPlayer player) {
-                return true;
+            public boolean shouldDisplayHolograms(HypixelPlayer player) {
+                return false;
             }
         });
     }

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCMuseumDisplay.java

@@ -1,5 +1,6 @@
 package net.swofty.type.hub.npcs;
 
+import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
 import net.minestom.server.coordinate.Pos;
 import net.swofty.type.generic.data.HypixelDataHandler;
 import net.swofty.type.generic.data.datapoints.DatapointString;
@@ -36,7 +37,7 @@ public String[] holograms(HypixelPlayer p) {
             if (dataHandler == null) {
                 dataHandler = HypixelDataHandler.getOfOfflinePlayer(currentlyViewing);
             }
-			String username = HypixelDataHandler.getPotentialIGNFromUUID(profileUUID);
+			String username = LegacyComponentSerializer.legacySection().serialize(p.getColouredName());
 			String profileName = skyblockHandler.get(SkyBlockDataHandler.Data.PROFILE_NAME, DatapointString.class).getValue();
 
 			return new String[]{

type.hub/src/main/java/net/swofty/type/hub/npcs/NPCTiaTheFairy.java

@@ -1,5 +1,6 @@
 package net.swofty.type.hub.npcs;
 
+import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
 import net.minestom.server.coordinate.Pos;
 import net.swofty.type.generic.data.datapoints.DatapointToggles;
 import net.swofty.type.generic.entity.npc.HypixelNPC;
@@ -60,7 +61,7 @@ public DialogueSet[] dialogues(HypixelPlayer player) {
         return Stream.of(
                 DialogueSet.builder()
                         .key("hello").lines(new String[]{
-                                "Welcome to the Fairy Pond! I am Tia.",
+                                "Welcome to the §dFairy Pond§f, " + LegacyComponentSerializer.legacySection().serialize(player.getColouredName()) + "! I am Tia.",
                                 "You may have noticed some strange orbs laying around the island.",
                                 "They are the souls of my fallen sisters.",
                                 "If you find any more during your travels, please bring them back to me!"

type.hub/src/main/java/net/swofty/type/hub/npcs/villagers/VillagerLibrarian.java

@@ -4,16 +4,14 @@
 import net.minestom.server.entity.VillagerProfession;
 import net.swofty.type.generic.entity.npc.HypixelNPC;
 import net.swofty.type.generic.entity.npc.configuration.VillagerConfiguration;
+import net.swofty.type.generic.event.custom.NPCInteractEvent;
 import net.swofty.type.generic.user.HypixelPlayer;
 import net.swofty.type.hub.gui.GUIShopLibrarian;
-import net.swofty.type.hub.gui.rosetta.GUIStarlightArmor;
 import net.swofty.type.skyblockgeneric.mission.MissionData;
 import net.swofty.type.skyblockgeneric.user.SkyBlockPlayer;
 
 import java.util.stream.Stream;
 
-import net.swofty.type.generic.event.custom.NPCInteractEvent;
-
 public class VillagerLibrarian extends HypixelNPC {
     public VillagerLibrarian() {
         super(new VillagerConfiguration(){
@@ -24,7 +22,7 @@ public String[] holograms(HypixelPlayer player) {
 
             @Override
             public Pos position(HypixelPlayer player) {
-                return new Pos(-35, 69, -112, -45, 0);
+                return new Pos(-68.5, 70, -79.5, -45, 0);
             }
 
             @Override