From de043e6f7b9c85786b708c2e9cb4507e01fd1e4c Mon Sep 17 00:00:00 2001
From: ArikSquad <75741608+ArikSquad@users.noreply.github.com>
Date: Sun, 28 Dec 2025 01:39:30 +0200
Subject: [PATCH] feat: some achievements

---
 configuration/achievements/skyblock/challenge.yml      | 10 +++++-----
 .../java/net/swofty/type/hub/gui/GUIClaimCake.java     |  1 +
 .../type/skyblockgeneric/commands/WikiThisCommand.java |  2 +-
 .../mission/missions/MissionTalkToVillagers.java       |  1 +
 .../skyblockgeneric/user/fairysouls/FairySoul.java     |  1 +
 5 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/configuration/achievements/skyblock/challenge.yml b/configuration/achievements/skyblock/challenge.yml
index 480daff16..7cddcc0ee 100644
--- a/configuration/achievements/skyblock/challenge.yml
+++ b/configuration/achievements/skyblock/challenge.yml
@@ -895,12 +895,12 @@ achievements:
     trigger: "skyblock.time_to_start_fishing_trigger"
     goal: 1
 
-  - id: "skyblock.wow_that_s_useful"
+  - id: "skyblock.wow_thats_useful"
     name: "Wow, that's useful!"
     description: "Use the /wiki, /wikithis, or /wikihand command to view the Official Hypixel Wiki."
     type: CHALLENGE
     points: 5
-    trigger: "skyblock.wow_that_s_useful_trigger"
+    trigger: "skyblock.wow_thats_useful_trigger"
     goal: 1
 
   - id: "skyblock.at_the_speed_of_light"
@@ -1412,8 +1412,8 @@ achievements:
     description: "Find 20 fairy souls."
     type: CHALLENGE
     points: 10
-    trigger: "skyblock.soul_hunter_trigger"
-    goal: 1
+    trigger: "skyblock.fairy_soul_found"
+    goal: 20
 
   - id: "skyblock.a_challenging_climb"
     name: "A Challenging Climb"
@@ -1524,7 +1524,7 @@ achievements:
     description: "Find a fairy soul."
     type: CHALLENGE
     points: 5
-    trigger: "skyblock.lost_soul_trigger"
+    trigger: "skyblock.fairy_soul_found"
     goal: 1
 
   - id: "skyblock.your_big_break"
diff --git a/type.hub/src/main/java/net/swofty/type/hub/gui/GUIClaimCake.java b/type.hub/src/main/java/net/swofty/type/hub/gui/GUIClaimCake.java
index cf8e1e3eb..e45c4ec4e 100644
--- a/type.hub/src/main/java/net/swofty/type/hub/gui/GUIClaimCake.java
+++ b/type.hub/src/main/java/net/swofty/type/hub/gui/GUIClaimCake.java
@@ -50,6 +50,7 @@ public void run(InventoryPreClickEvent e, HypixelPlayer p) {
                 player.addAndUpdateItem(item);
                 p.closeInventory();
                 player.sendMessage("§aYou claimed §cNew Year Cake§a!");
+                player.getAchievementHandler().completeAchievement("skyblock.happy_new_year");
             }
 
             @Override
diff --git a/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/commands/WikiThisCommand.java b/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/commands/WikiThisCommand.java
index cdd49a8bd..0278c26d1 100644
--- a/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/commands/WikiThisCommand.java
+++ b/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/commands/WikiThisCommand.java
@@ -61,7 +61,7 @@ public void registerUsage(MinestomCommand command) {
 
             player.sendMessage(line1);
             player.sendMessage(line2);
-
+            player.getAchievementHandler().completeAchievement("skyblock.wow_thats_useful");
         });
     }
 }
diff --git a/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/mission/missions/MissionTalkToVillagers.java b/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/mission/missions/MissionTalkToVillagers.java
index 0a507da5e..c1fc58ed8 100644
--- a/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/mission/missions/MissionTalkToVillagers.java
+++ b/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/mission/missions/MissionTalkToVillagers.java
@@ -92,6 +92,7 @@ public void onEnd(SkyBlockPlayer player, Map<String, Object> customData, Mission
         player.getSkyblockDataHandler().get(net.swofty.type.skyblockgeneric.data.SkyBlockDataHandler.Data.COINS, DatapointDouble.class).setValue(
                 player.getSkyblockDataHandler().get(net.swofty.type.skyblockgeneric.data.SkyBlockDataHandler.Data.COINS, DatapointDouble.class).getValue() + 1000
         );
+        player.getAchievementHandler().completeAchievement("skyblock.quest_complete");
     }
 
     @Override
diff --git a/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/user/fairysouls/FairySoul.java b/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/user/fairysouls/FairySoul.java
index f35c5afcf..1e20f0b17 100644
--- a/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/user/fairysouls/FairySoul.java
+++ b/type.skyblockgeneric/src/main/java/net/swofty/type/skyblockgeneric/user/fairysouls/FairySoul.java
@@ -51,6 +51,7 @@ public void collect(SkyBlockPlayer player) {
             player.getSkyblockDataHandler()
                     .get(SkyBlockDataHandler.Data.FAIRY_SOULS, DatapointFairySouls.class)
                     .setValue(fairySouls);
+            player.getAchievementHandler().addProgressByTrigger("skyblock.fairy_soul_found", 1);
             return;
         }