Fixes #568: MockFile.Copy does not honor AccessFileShare on MockFileData (#569)

* fixes #568, MockFile.Copy should honor FileShare

* add missing coverage on MockFile.Move

Co-authored-by: Florian Greinacher <fgreinacher@users.noreply.github.com>

Author: pianomanjh

System.IO.Abstractions.TestingHelpers.Tests/MockFileCopyTests.cs

@@ -381,5 +381,24 @@ public void MockFile_Copy_ShouldWorkWithRelativePaths()
 
             Assert.That(fileSystem.File.Exists(destinationFile));
         }
+
+        [Test]
+        public void MockFile_Copy_ShouldThrowIOExceptionForInvalidFileShare()
+        {
+            string sourceFileName = XFS.Path(@"c:\source\demo.txt");
+            var sourceContents = new MockFileData("Source content")
+            {
+                AllowedFileShare = FileShare.None
+            };
+            var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
+            {
+                {sourceFileName, sourceContents}
+            });
+            fileSystem.AddDirectory(XFS.Path(@"c:\something"));
+
+            TestDelegate action = () => fileSystem.File.Copy(sourceFileName, XFS.Path(@"c:\something\demo.txt"));
+
+            Assert.Throws<IOException>(action);
+        }
     }
 }

System.IO.Abstractions.TestingHelpers.Tests/MockFileMoveTests.cs

@@ -381,5 +381,39 @@ public void MockFile_Move_ShouldRetainMetadata()
 
             Assert.That(fileSystem.File.GetCreationTimeUtc(destFilePath), Is.EqualTo(creationTime.UtcDateTime));
         }
+
+        [Test]
+        public void MockFile_Move_ShouldThrowExceptionWhenSourceFileShare_Is_Not_Delete()
+        {
+            string sourceFileReadDelete = XFS.Path(@"c:\something\IHaveReadDelete.txt");
+            string sourceFileDelete = XFS.Path(@"c:\something\IHaveDelete.txt");
+            string sourceFileRead = XFS.Path(@"c:\something\IHaveRead.txt");
+            string sourceFileNone = XFS.Path(@"c:\something\IHaveNone.txt");
+            var fileSystem = new MockFileSystem(new Dictionary<string, MockFileData>
+            {
+                { sourceFileDelete, new MockFileData("") { AllowedFileShare = FileShare.Delete } },
+                { sourceFileRead, new MockFileData("") { AllowedFileShare = FileShare.Read } },
+                { sourceFileReadDelete, new MockFileData("") { AllowedFileShare = FileShare.Delete | FileShare.Read } },
+                { sourceFileNone, new MockFileData("") { AllowedFileShare = FileShare.None } },
+            });
+
+            AssertMoveSuccess(sourceFileReadDelete);
+            AssertMoveSuccess(sourceFileDelete);
+            AssertMoveThrowsIOException(sourceFileRead);
+            AssertMoveThrowsIOException(sourceFileNone);
+
+            void AssertMoveThrowsIOException(string sourceFile)
+            {
+                var target = sourceFile + ".moved";
+                Assert.Throws<IOException>(() => fileSystem.File.Move(sourceFile, target));
+            }
+
+            void AssertMoveSuccess(string sourceFile)
+            {
+                var target = sourceFile + ".moved";
+                fileSystem.File.Move(sourceFile, target);
+                Assert.That(fileSystem.File.Exists(target), Is.True);
+            }
+        }
     }
 }

System.IO.Abstractions.TestingHelpers/MockFile.cs

@@ -122,6 +122,7 @@ public override void Copy(string sourceFileName, string destFileName, bool overw
             }
 
             var sourceFileData = mockFileDataAccessor.GetFile(sourceFileName);
+            sourceFileData.CheckFileAccess(sourceFileName, FileAccess.Read);
             mockFileDataAccessor.AddFile(destFileName, new MockFileData(sourceFileData));
         }