JShellWrapper changed logic to know when the code is has a syntax error + tests

Author: Alathreon

JShellWrapper/src/main/java/JShellWrapper.java

@@ -59,9 +59,9 @@ private void ok(PrintStream processOut) {
     private EvalResult eval(JShell shell, String code, AtomicBoolean hasStopped) {
         List<SnippetEvent> resultEvents = new ArrayList<>();
         JShellEvalAbortion abortion = null;
-        do {
+        while(!code.isEmpty()) {
             var completion = shell.sourceCodeAnalysis().analyzeCompletion(clean(code));
-            if(completion.completeness() == SourceCodeAnalysis.Completeness.DEFINITELY_INCOMPLETE) {
+            if(!completion.completeness().isComplete()) {
                 abortion = new JShellEvalAbortion(code, completion.remaining(), new JShellEvalAbortionCause.SyntaxErrorAbortionCause());
                 break;
             }
@@ -76,7 +76,7 @@ private EvalResult eval(JShell shell, String code, AtomicBoolean hasStopped) {
                 break;
             }
             code = completion.remaining();
-        } while(!code.isEmpty());
+        }
         return new EvalResult(resultEvents, abortion);
     }
     private JShellEvalAbortionCause handleEvents(JShell shell, List<SnippetEvent> evalEvents, List<SnippetEvent> resultEvents) {

JShellWrapper/src/test/java/JShellWrapperTest.java

@@ -205,6 +205,7 @@ void testRejected() {
     }
     @Test
     void testSyntaxError() {
+        // DEFINITELY_INCOMPLETE
         evalTest("""
             eval
             1
@@ -217,6 +218,31 @@ void testSyntaxError() {
                 print(\\n
                 false
                 """);
+        // CONSIDERED_INCOMPLETE
+        evalTest("""
+            eval
+            1
+            while(true)""",
+                """
+                OK
+                0
+                SYNTAX_ERROR
+                while(true)
+                while(true)\\n
+                false
+                """);
+        evalTest("""
+            eval
+            1
+            for(int i = 0; i < 10; i++)""",
+                """
+                OK
+                0
+                SYNTAX_ERROR
+                for(int i = 0; i < 10; i++)
+                for(int i = 0; i < 10; i++)\\n
+                false
+                """);
     }
     @Test
     void testRejectedAndMultiples() {