Fix Java 9 Runtime Issues (#382)

* Added Azul zulu-8 JDK

* Added JAVA_HOME to zulu-8 matrix entry

* Removed jdk entry from zulu-8 matrix entry

* Added cryptographic extensions to Zulu JDK install

* Fixed mkdir to use -p

* Fixed mkdir to use -p

* Fixed unzip command

* Moved cryptographic extensions install to before_script

* Added sudo before unzip command

* Fixed path to security directory.

* Fixed key_url yaml entry

* Removed Oracle JDK from apt install because it is preinstalled

* Changed wget flag

* Added explicit paths to extract policy files

* Changed JAVA_HOME to zulu home directory

* Added Oracle JDK 9 and Zulu 9 to test matrix

* Fixed JCE installation for Zulu Java 9

* Removed OpenJDK 9 from Travis CI config because it isn't supported

* Fixes Java 9 support for serialization model.
See: #356

* Rolled back MantaVersion that was mistakenly checked in

* Added additional commentary about details of Travis CI config

* Fixed type check warnings in serializer

* Fixed deprecation warnings

* Fixed deprecation warnings

Author: dekobon

.travis.yml

@@ -2,18 +2,36 @@ dist: trusty
 language: java
 # We now cache the Maven dependencies directory for faster builds
 cache:
+  apt: true
   directories:
   - $HOME/.m2
-sudo: false
+  - $HOME/.downloads
+sudo: true
 
 addons:
   apt:
+    sources:
+      - sourceline: 'deb http://repos.azulsystems.com/ubuntu stable main'
+        key_url: 'http://repos.azulsystems.com/RPM-GPG-KEY-azulsystems'
     packages:
-      - oracle-java8-installer
-      - oracle-java8-unlimited-jce-policy
+      - zulu-8
+      - zulu-9
+
+# Oracle JDK 8 and the OpenJDK 8 are both installed by default by TravisCI
+# Additionally, they both have the unlimited JCE policy installed as well.
+# This is why we do not explicitly installed them in our Travis CI
+# configuration.
 
 before_install:
   - echo 'MAVEN_OPTS="-Dorg.slf4j.simpleLogger.defaultLogLevel=warn"' >~/.mavenrc
+  - mkdir -p $HOME/.downloads
+  - wget -N -q -O $HOME/.downloads/ZuluJCEPolicies.zip 'https://cdn.azul.com/zcek/bin/ZuluJCEPolicies.zip'
+  # The SHA256 checksum for JCE for Azul will break if Azul updates their archive.
+  # If so, you will need to update the fingerprint below after verifying the
+  # authenticity of the archive.
+  - echo "8021a28b8cac41b44f1421fd210a0a0822fcaf88d62d2e70a35b2ff628a8675a  $HOME/.downloads/ZuluJCEPolicies.zip" | sha256sum -c
+  - sudo unzip -o -j $HOME/.downloads/ZuluJCEPolicies.zip ZuluJCEPolicies/local_policy.jar ZuluJCEPolicies/US_export_policy.jar -d /usr/lib/jvm/zulu-8-amd64/jre/lib/security
+  - sudo unzip -o -j $HOME/.downloads/ZuluJCEPolicies.zip ZuluJCEPolicies/local_policy.jar ZuluJCEPolicies/US_export_policy.jar -d /usr/lib/jvm/zulu-9-amd64/lib/security
 
 matrix:
   fast_finish: true
@@ -36,5 +54,22 @@ matrix:
         - DESC="openjdk8 unit tests"
         - CMD="mvn clean test -Dcheckstyle.skip=true"
         - LANG=en_US.utf8
+    # unit tests (zulu-8)
+    - env:
+        - JAVA_HOME=/usr/lib/jvm/zulu-8-amd64
+        - DESC="zulu-8 unit tests"
+        - CMD="mvn clean test -Dcheckstyle.skip=true"
+        - LANG=en_US.utf8
+    - jdk: oraclejdk9
+      env:
+        - DESC="oraclejdk9 unit tests"
+        - CMD="mvn clean test -Dcheckstyle.skip=true"
+        - LANG=en_US.utf8
+    # unit tests (zulu-9)
+    - env:
+        - JAVA_HOME=/usr/lib/jvm/zulu-9-amd64
+        - DESC="zulu-9 unit tests"
+        - CMD="mvn clean test -Dcheckstyle.skip=true"
+        - LANG=en_US.utf8
 
 script: echo ${CMD}; ${CMD}

java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/BaseBlockCipherSerializer.java

@@ -25,13 +25,14 @@
 import org.bouncycastle.jcajce.provider.symmetric.util.BlockCipherProvider;
 import org.bouncycastle.jcajce.spec.GOST28147ParameterSpec;
 import org.bouncycastle.jcajce.util.BCJcaJceHelper;
-import org.objenesis.instantiator.sun.MagicInstantiator;
+import org.objenesis.instantiator.sun.UnsafeFactoryInstantiator;
 
 import javax.crypto.spec.GCMParameterSpec;
 import javax.crypto.spec.IvParameterSpec;
 import javax.crypto.spec.PBEParameterSpec;
 import javax.crypto.spec.RC2ParameterSpec;
 import javax.crypto.spec.RC5ParameterSpec;
+
 import java.lang.reflect.Field;
 import java.security.AlgorithmParameters;
 
@@ -141,25 +142,25 @@ private void registerClasses(final Kryo kryo) {
         kryo.register(BufferedBlockCipher.class);
         kryo.register(bufferedGenericBlockCipherClass,
                 new CompatibleFieldSerializer<>(kryo, bufferedGenericBlockCipherClass))
-                .setInstantiator(new MagicInstantiator<>(bufferedGenericBlockCipherClass));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(bufferedGenericBlockCipherClass));
         kryo.register(SICBlockCipher.class)
-                .setInstantiator(new MagicInstantiator<>(SICBlockCipher.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(SICBlockCipher.class));
         kryo.register(AlgorithmParameters.class);
         kryo.register(BCJcaJceHelper.class);
         kryo.register(ParametersWithIV.class)
-                .setInstantiator(new MagicInstantiator<>(ParametersWithIV.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(ParametersWithIV.class));
         kryo.register(KeyParameter.class)
-                .setInstantiator(new MagicInstantiator<>(KeyParameter.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(KeyParameter.class));
         kryo.register(paddedBufferedBlockCipherClass)
-                .setInstantiator(new MagicInstantiator<>(paddedBufferedBlockCipherClass));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(paddedBufferedBlockCipherClass));
         kryo.register(CBCBlockCipher.class)
-                .setInstantiator(new MagicInstantiator<>(CBCBlockCipher.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(CBCBlockCipher.class));
         kryo.register(AEADParameters.class, new CompatibleFieldSerializer<>(kryo, AEADParameters.class))
-                .setInstantiator(new MagicInstantiator<>(AEADParameters.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(AEADParameters.class));
         kryo.register(aeadGenericBlockCipherClass, new CompatibleFieldSerializer<>(kryo, aeadGenericBlockCipherClass))
-                .setInstantiator(new MagicInstantiator<>(aeadGenericBlockCipherClass));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(aeadGenericBlockCipherClass));
         kryo.register(GCMBlockCipher.class, new CompatibleFieldSerializer<>(kryo, GCMBlockCipher.class))
-                .setInstantiator(new MagicInstantiator<>(GCMBlockCipher.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(GCMBlockCipher.class));
         kryo.register(RC2ParameterSpec.class);
         kryo.register(RC5ParameterSpec.class);
         kryo.register(GCMParameterSpec.class);

java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/CipherSerializer.java

@@ -14,6 +14,7 @@
 import com.esotericsoftware.kryo.serializers.JavaSerializer;
 import org.bouncycastle.jcajce.provider.symmetric.AES;
 import org.objenesis.instantiator.sun.MagicInstantiator;
+import org.objenesis.instantiator.sun.UnsafeFactoryInstantiator;
 
 import javax.crypto.Cipher;
 import javax.crypto.spec.SecretKeySpec;
@@ -94,10 +95,10 @@ private void registerClasses(final Kryo kryo) {
         kryo.register(IdentityHashMap.class, new JavaSerializer());
 
         kryo.register(java.lang.ref.WeakReference.class)
-                .setInstantiator(new MagicInstantiator<>(java.lang.ref.WeakReference.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(java.lang.ref.WeakReference.class));
 
         kryo.register(java.security.AlgorithmParameters.class)
-                .setInstantiator(new MagicInstantiator<>(java.security.AlgorithmParameters.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(java.security.AlgorithmParameters.class));
 
         kryo.register(SecretKeySpec.class, new JavaSerializer());
 
@@ -142,7 +143,7 @@ private void registerWithCompatSerializerMagicInstantiator(final Kryo kryo, fina
 
         if (clazz != null) {
             kryo.register(clazz, new CompatibleFieldSerializer<>(kryo, clazz))
-                    .setInstantiator(new MagicInstantiator<>(clazz));
+                    .setInstantiator(new UnsafeFactoryInstantiator<>(clazz));
         }
     }
 
@@ -170,7 +171,7 @@ private void registerWithMagicInstantiator(final Kryo kryo, final String classNa
         Class<?> clazz = findClass(className);
 
         if (clazz != null) {
-            kryo.register(clazz).setInstantiator(new MagicInstantiator<>(clazz));
+            kryo.register(clazz).setInstantiator(new UnsafeFactoryInstantiator<>(clazz));
         }
     }
 

java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/EncryptionStateSerializer.java

@@ -21,7 +21,7 @@
 import com.joyent.manta.util.HmacOutputStream;
 import org.bouncycastle.crypto.macs.HMac;
 import org.bouncycastle.jcajce.io.CipherOutputStream;
-import org.objenesis.instantiator.sun.MagicInstantiator;
+import org.objenesis.instantiator.sun.UnsafeFactoryInstantiator;
 
 import javax.crypto.Cipher;
 import javax.crypto.SecretKey;
@@ -72,7 +72,7 @@ public EncryptionStateSerializer(final Kryo kryo,
      */
     private void registerClasses(final Kryo kryo) {
         kryo.register(EncryptionContext.class)
-                .setInstantiator(new MagicInstantiator<>(EncryptionContext.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(EncryptionContext.class));
         kryo.register(SupportedCipherDetails.class, new SupportedCipherDetailsSerializer());
         kryo.register(AesCtrCipherDetails.class, new SupportedCipherDetailsSerializer());
         kryo.register(AesCbcCipherDetails.class, new SupportedCipherDetailsSerializer());
@@ -85,9 +85,9 @@ private void registerClasses(final Kryo kryo) {
                 "CloseShieldOutputStream reference must not be null");
 
         kryo.register(closeShieldStreamClass)
-                .setInstantiator(new MagicInstantiator<>(closeShieldStreamClass));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(closeShieldStreamClass));
         kryo.register(CipherOutputStream.class)
-                .setInstantiator(new MagicInstantiator<>(CipherOutputStream.class));
+                .setInstantiator(new UnsafeFactoryInstantiator<>(CipherOutputStream.class));
     }
 
     /**

java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/ReflectionUtils.java

@@ -115,6 +115,7 @@ static Field getField(final Class<?> clazz, final String name) {
      * @param object object to read from
      * @return field's value
      */
+    @SuppressWarnings("deprecation")
     static Object readField(final Field field, final Object object) {
         Objects.requireNonNull(field, "Field must not be null");
         Objects.requireNonNull(object, "Object must not be null");
@@ -142,6 +143,7 @@ static Object readField(final Field field, final Object object) {
      * @param target target object
      * @param value object to write
      */
+    @SuppressWarnings("deprecation")
     static void writeField(final Field field, final Object target, final Object value) {
         Objects.requireNonNull(field, "Field must not be null");
         Objects.requireNonNull(target, "Target must not be null");