Resolves #368 by adding checkstyle explicit line ending and test fixes (#369)

Author: tjcelaya

checkstyle.xml

@@ -33,7 +33,9 @@
 
     <!-- Checks whether files end with a new line.                        -->
     <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
-    <module name="NewlineAtEndOfFile"/>
+    <module name="NewlineAtEndOfFile">
+        <property name="lineSeparator" value="lf"/>
+    </module>
 
     <!-- Checks that property files contain the same keys.         -->
     <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->

java-manta-client-unshaded/src/test/java/com/joyent/manta/client/MantaObjectDepthComparatorTest.java

@@ -109,8 +109,9 @@ private static List<MantaObject> fileObjects(final MantaObject dirObject, final
 
         for (int i = 0; i < number; i++) {
             final MantaObject object = mock(MantaObject.class);
+            final int segmentChar = (number + i) % 26;
             String path = dirObject.getPath() + SEPARATOR
-                    + StringUtils.repeat((char)(97 + number + i), 4) + ".json";
+                    + StringUtils.repeat(((char)(97 + segmentChar) ), 4) + ".json";
             when(object.getPath()).thenReturn(path);
             when(object.getType()).thenReturn(MantaObject.MANTA_OBJECT_TYPE_OBJECT);
             when(object.getContentType()).thenReturn(ContentType.APPLICATION_JSON.toString());
@@ -129,7 +130,8 @@ private static List<MantaObject> dirObjects(final int depth) {
         path.append("stor");
 
         for (int i = 3; i <= depth; i++) {
-            path.append(SEPARATOR).append(StringUtils.repeat((char)(97 + depth + i), 3));
+            final int segmentChar = (depth + i) % 26;
+            path.append(SEPARATOR).append(StringUtils.repeat(((char)(97 + segmentChar) ), 3));
             MantaObject object = mockDirectory(path);
             objects.add(object);
         }

java-manta-client-unshaded/src/test/java/com/joyent/manta/client/crypto/SecretKeyUtilsTest.java

@@ -11,14 +11,14 @@
 import org.testng.Assert;
 import org.testng.annotations.Test;
 
-import javax.crypto.SecretKey;
 import java.io.File;
 import java.io.IOException;
 import java.net.URI;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.Arrays;
+import javax.crypto.SecretKey;
 
 @Test
 public class SecretKeyUtilsTest {
@@ -68,7 +68,7 @@ public void canLoadKeyFromURIPath() throws IOException {
         File file = File.createTempFile("ciphertext-", ".data");
         FileUtils.forceDeleteOnExit(file);
         FileUtils.writeByteArrayToFile(file, keyBytes);
-        URI uri = URI.create("file://" + file.getAbsolutePath());
+        URI uri = file.toURI();
 
         SecretKey expected = SecretKeyUtils.loadKey(keyBytes, AesGcmCipherDetails.INSTANCE_128_BIT);
         SecretKey actual = SecretKeyUtils.loadKeyFromPath(Paths.get(uri), AesGcmCipherDetails.INSTANCE_128_BIT);