Fixes #346 (#351)

* Fixes #346

* Updated changelog.

Author: dekobon

CHANGELOG.md

@@ -18,6 +18,7 @@ This project aims to adhere to [Semantic Versioning](http://semver.org/).
  - Setting `manta.retries`/`MANTA_HTTP_RETRIES` to 0 would print `Retry of failed requests is disabled` but
    leave the default Apache HttpClient [retry behavior](https://hc.apache.org/httpcomponents-client-4.5.x/tutorial/html/fundamentals.html#d5e316).
  - [Content type is set for file object in directory listing when it isn't available](https://github.com/joyent/java-manta/issues/341)
+ - [Fixes validation guard clauses that are not validating anything](https://github.com/joyent/java-manta/issues/346)
 ### Changed
  - Validation of paths passed to `MantaClient` is now more consistently strict.
    More useful errors should be thrown sooner for invalid paths, without any

java-manta-client-unshaded/src/main/java/com/joyent/manta/client/MantaClient.java

@@ -2009,7 +2009,7 @@ public MantaJob getJob(final UUID jobId) throws IOException {
             }
         }
 
-        Validate.notNull("Job returned must not be null");
+        Validate.notNull(job, "Job returned must not be null");
         return job;
     }
 

java-manta-client-unshaded/src/main/java/com/joyent/manta/client/crypto/MantaEncryptedObjectInputStream.java

@@ -818,7 +818,7 @@ public Long getContentLength() {
         }
 
         Long plaintextSize = super.getContentLength();
-        Validate.notNull("Content-length header wasn't set by server");
+        Validate.notNull(plaintextSize, "Content-length header wasn't set by server");
         return this.cipherDetails.plaintextSize(plaintextSize);
     }
 }

java-manta-client-unshaded/src/main/java/com/joyent/manta/client/jobs/MantaJobBuilder.java

@@ -97,7 +97,7 @@ public Run lookupJob(final MantaJob job) {
      * @return a fluent interface providing job management options
      */
     public Run lookupJob(final UUID jobId) {
-        Validate.notNull("Job id must not be null");
+        Validate.notNull(jobId, "Job id must not be null");
 
         return new MantaJobBuilder.Run(this, jobId);
     }

java-manta-client-unshaded/src/main/java/com/joyent/manta/client/multipart/AbstractMultipartManager.java

@@ -144,7 +144,7 @@ public PART uploadPart(final UPLOAD upload,
                            final int partNumber,
                            final InputStream inputStream)
             throws IOException {
-        Validate.notNull("InputStream must not be null");
+        Validate.notNull(inputStream, "InputStream must not be null");
 
         if (inputStream.getClass().equals(FileInputStream.class)) {
             final FileInputStream fin = (FileInputStream)inputStream;
@@ -163,7 +163,7 @@ public PART uploadPart(final UPLOAD upload,
                            final int partNumber,
                            final long contentLength,
                            final InputStream inputStream) throws IOException {
-        Validate.notNull("InputStream must not be null");
+        Validate.notNull(inputStream, "InputStream must not be null");
 
         HttpEntity entity;