Skip to content

Commit 21e2553

Browse files
Add continue-on-error to cleanup job for improved resilience
1 parent 1312b88 commit 21e2553

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/deploy-v2-windows.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -801,6 +801,7 @@ jobs:
801801
if: always() && needs.deploy.result == 'success' && needs.deploy.outputs.RESOURCE_GROUP_NAME != '' && github.event.inputs.existing_webapp_url == '' && (github.event_name != 'workflow_dispatch' || github.event.inputs.cleanup_resources == 'true' || github.event.inputs.cleanup_resources == null)
802802
needs: [docker-build, deploy, e2e-test]
803803
runs-on: windows-latest
804+
continue-on-error: true
804805
env:
805806
RESOURCE_GROUP_NAME: ${{ needs.deploy.outputs.RESOURCE_GROUP_NAME }}
806807
AZURE_LOCATION: ${{ needs.deploy.outputs.AZURE_LOCATION }}
@@ -820,7 +821,6 @@ jobs:
820821
az login --service-principal -u ${{ secrets.AZURE_CLIENT_ID }} -p ${{ secrets.AZURE_CLIENT_SECRET }} --tenant ${{ secrets.AZURE_TENANT_ID }}
821822
az account set --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }}
822823
- name: Delete Resource Group Directly (Optimized Cleanup)
823-
continue-on-error: true
824824
shell: bash
825825
id: delete_rg
826826
run: |
@@ -844,8 +844,7 @@ jobs:
844844
if: always()
845845
shell: bash
846846
run: |
847-
azd auth logout
848-
az logout || echo "Warning: Failed to logout from Azure CLI"
847+
az logout
849848
echo "Logged out from Azure."
850849
851850
- name: Generate Cleanup Job Summary

0 commit comments

Comments
 (0)