Skip to content

Commit db8b255

Browse files
committed
chore: Coderabbit review of PRE_COMMIT_VERSION validation
1 parent df1fb32 commit db8b255

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Dockerfile.tools

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@ COPY tools/install/ /install/
2525
ARG PRE_COMMIT_VERSION=${PRE_COMMIT_VERSION:-latest}
2626
RUN touch /.env && \
2727
if [ "$PRE_COMMIT_VERSION" = "false" ]; then \
28-
echo "Vital software can't be skipped" && exit 1; \
28+
echo "ERROR: PRE_COMMIT_VERSION cannot be 'false' - pre-commit is required" >&2 && exit 1; \
29+
elif [ -z "$PRE_COMMIT_VERSION" ]; then \
30+
echo "ERROR: PRE_COMMIT_VERSION is required" >&2 && exit 1; \
2931
fi
3032
RUN /install/pre-commit.sh
3133

0 commit comments

Comments
 (0)