Skip to content

Commit 9517c80

Browse files
authored
A clearer condition about including update_mask. (#923)
IIUC, this field **must** be included if partial update is supported not **should** be included to support partial update. The latter sounds to me like: "If you want to support partial update, you **should but you don't have** to include `update_mask`. Instead you can include something else".
1 parent 83c133c commit 9517c80

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

aip/general/0134.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ message UpdateBookRequest {
8787
- The field **should** be [annotated as required][aip-203].
8888
- A `name` field **must** be included in the resource message. It **should**
8989
be called `name`.
90-
- A field mask **should** be included in order to support partial update. It
91-
**must** be of type `google.protobuf.FieldMask`, and it **should** be called
92-
`update_mask`.
90+
- If partial resource update is supported, a field mask **must** be included.
91+
It **must** be of type `google.protobuf.FieldMask`, and it **should** be
92+
called `update_mask`.
9393
- The fields used in the field mask correspond to the resource being updated
9494
(not the request message).
9595
- The field **may** be required or optional. If it is required, it **must**

0 commit comments

Comments
 (0)