Revert "Optimize SecurityContext#isInOneOf (#1874)" (#1875)

This reverts commit b404e1e.

This change needs more work because DefaultAuthorizationMap requires
equals() to be used the way it handles a wildcard Principal. This needs
to be fixed before the change can be made

Author: cshannon

activemq-broker/src/main/java/org/apache/activemq/security/SecurityContext.java

@@ -54,21 +54,21 @@ public SecurityContext(String userName) {
     }
 
     public boolean isInOneOf(Set<?> allowedPrincipals) {
-        for (Object allowedPrincipal : allowedPrincipals) {
-            if (contains(allowedPrincipal)) {
-                return true;
+        Iterator<?> allowedIter = allowedPrincipals.iterator();
+        HashSet<?> userPrincipals = new HashSet<Object>(getPrincipals());
+        while (allowedIter.hasNext()) {
+            Iterator<?> userIter = userPrincipals.iterator();
+            Object allowedPrincipal = allowedIter.next();
+            while (userIter.hasNext()) {
+                if (allowedPrincipal.equals(userIter.next()))
+                    return true;
             }
         }
         return false;
     }
 
     public abstract Set<Principal> getPrincipals();
 
-    public boolean contains(Object principal) {
-        Set<Principal> principals = getPrincipals();
-        return principals != null && principals.contains(principal);
-    }
-
     public String getUserName() {
         return userName;
     }