Merge pull request #295 from riptano/CPP-801

CPP-801 - Verify the driver handles NULLs in collections

Author: mikefero

cpp-driver/gtests/src/unit/tests/test_value.cpp

@@ -16,12 +16,15 @@
 
 #include <gtest/gtest.h>
 
+#include "buffer.hpp"
 #include "cassandra.h"
+#include "string.hpp"
 #include "value.hpp"
 
 #include <time.h>
 
 using namespace datastax::internal::core;
+using namespace datastax;
 
 // The following CassValue's are used in tests as "bad data".
 
@@ -107,3 +110,81 @@ TEST(ValueUnitTest, BadDecimal) {
   EXPECT_EQ(cass_value_get_decimal(CassValue::to(&invalid_value), &varint, &varint_size, &scale),
             CASS_ERROR_LIB_NOT_ENOUGH_DATA);
 }
+
+TEST(ValueUnitTest, NullElementInCollectionList) {
+  const char input[12] = {
+    -1, -1, -1, -1,            // Element 1 is NULL
+    0,  0,  0,  4,  0, 0, 0, 2 // Size (int32_t) and contents of element 2
+  };
+  Decoder decoder(input, 12);
+  DataType::ConstPtr element_data_type(new DataType(CASS_VALUE_TYPE_INT));
+  CollectionType::ConstPtr data_type = CollectionType::list(element_data_type, false);
+  Value value(data_type, 2, decoder);
+  ASSERT_EQ(cass_true, cass_value_is_collection(CassValue::to(&value)));
+
+  CassIterator* it = cass_iterator_from_collection(CassValue::to(&value));
+  EXPECT_EQ(cass_true, cass_iterator_next(it));
+  const CassValue* element = cass_iterator_get_value(it);
+  EXPECT_EQ(cass_true, cass_value_is_null(element));
+  cass_int32_t element_value;
+  EXPECT_EQ(cass_true, cass_iterator_next(it));
+  EXPECT_EQ(CASS_OK, cass_value_get_int32(element, &element_value));
+  EXPECT_EQ(2, element_value);
+  cass_iterator_free(it);
+}
+
+TEST(ValueUnitTest, NullElementInCollectionMap) {
+  const char input[21] = {
+    -1, -1, -1, -1,               // Key 1 is NULL
+    0,  0,  0,  4,  0,   0, 0, 2, // Size (int32_t) and contents of value 1
+    0,  0,  0,  1,  'a',          // Key 2 is a
+    -1, -1, -1, -1                // Value 2 is NULL
+  };
+  Decoder decoder(input, 21);
+  DataType::ConstPtr key_data_type(new DataType(CASS_VALUE_TYPE_TEXT));
+  DataType::ConstPtr value_data_type(new DataType(CASS_VALUE_TYPE_INT));
+  CollectionType::ConstPtr data_type = CollectionType::map(key_data_type, value_data_type, false);
+  Value value(data_type, 2, decoder);
+  ASSERT_EQ(cass_true, cass_value_is_collection(CassValue::to(&value)));
+
+  CassIterator* it = cass_iterator_from_collection(CassValue::to(&value));
+  EXPECT_EQ(cass_true, cass_iterator_next(it));
+  const CassValue* element = cass_iterator_get_value(it);
+  EXPECT_EQ(cass_true, cass_value_is_null(element));
+  cass_int32_t value_value;
+  EXPECT_EQ(cass_true, cass_iterator_next(it));
+  EXPECT_EQ(CASS_OK, cass_value_get_int32(element, &value_value));
+  EXPECT_EQ(2, value_value);
+
+  EXPECT_EQ(cass_true, cass_iterator_next(it));
+  element = cass_iterator_get_value(it);
+  const char* key_value = NULL;
+  size_t key_value_length = 0;
+  EXPECT_EQ(CASS_OK, cass_value_get_string(element, &key_value, &key_value_length));
+  EXPECT_EQ("a", String(key_value, key_value_length));
+  EXPECT_EQ(cass_true, cass_iterator_next(it));
+  EXPECT_EQ(cass_true, cass_value_is_null(element));
+  cass_iterator_free(it);
+}
+
+TEST(ValueUnitTest, NullElementInCollectionSet) {
+  const char input[12] = {
+    0,  0,  0,  4,  0, 0, 0, 2, // Size (int32_t) and contents of element 1
+    -1, -1, -1, -1,             // Element 2 is NULL
+  };
+  Decoder decoder(input, 12);
+  DataType::ConstPtr element_data_type(new DataType(CASS_VALUE_TYPE_INT));
+  CollectionType::ConstPtr data_type = CollectionType::set(element_data_type, false);
+  Value value(data_type, 2, decoder);
+  ASSERT_EQ(cass_true, cass_value_is_collection(CassValue::to(&value)));
+
+  CassIterator* it = cass_iterator_from_collection(CassValue::to(&value));
+  EXPECT_EQ(cass_true, cass_iterator_next(it));
+  const CassValue* element = cass_iterator_get_value(it);
+  cass_int32_t element_value;
+  EXPECT_EQ(CASS_OK, cass_value_get_int32(element, &element_value));
+  EXPECT_EQ(2, element_value);
+  EXPECT_EQ(cass_true, cass_iterator_next(it));
+  EXPECT_EQ(cass_true, cass_value_is_null(element));
+  cass_iterator_free(it);
+}