CPP-806 Fix handling of no contact points (#280)

Author: mpenick

cpp-driver/gtests/src/unit/tests/test_cluster.cpp

@@ -957,3 +957,20 @@ TEST_F(ClusterUnitTest, ReconnectionPolicy) {
   EXPECT_GE(policy->scheduled_delay_count(), 2u);
   EXPECT_EQ(3u, mock_cluster.connection_attempts(1)); // Includes initial connection attempt
 }
+
+TEST_F(ClusterUnitTest, NoContactPoints) {
+  // No cluster needed
+
+  AddressVec contact_points; // Empty
+
+  Future::Ptr connect_future(new Future());
+  ClusterConnector::Ptr connector(
+      new ClusterConnector(contact_points, PROTOCOL_VERSION,
+                           bind_callback(on_connection_connected, connect_future.get())));
+  connector->connect(event_loop());
+
+  ASSERT_TRUE(connect_future->wait_for(WAIT_FOR_TIME))
+      << "Timed out waiting for cluster to connect";
+  ASSERT_TRUE(connect_future->error());
+  EXPECT_EQ(connect_future->error()->code, CASS_ERROR_LIB_NO_HOSTS_AVAILABLE);
+}

cpp-driver/gtests/src/unit/tests/test_session.cpp

@@ -610,3 +610,17 @@ TEST_F(SessionUnitTest, HostListenerNodeDown) {
 
   ASSERT_EQ(0u, listener->event_count());
 }
+
+TEST_F(SessionUnitTest, NoContactPoints) {
+  // No cluster needed
+
+  Config config;
+  config.contact_points().clear();
+
+  Session session;
+  Future::Ptr connect_future(session.connect(config));
+  ASSERT_TRUE(connect_future->wait_for(WAIT_FOR_TIME))
+      << "Timed out waiting for session to connect";
+  ASSERT_TRUE(connect_future->error());
+  EXPECT_EQ(connect_future->error()->code, CASS_ERROR_LIB_NO_HOSTS_AVAILABLE);
+}

cpp-driver/src/cluster_connector.cpp

@@ -104,9 +104,7 @@ Cluster::Ptr ClusterConnector::release_cluster() {
 void ClusterConnector::internal_resolve_and_connect() {
   inc_ref();
 
-  assert(!contact_points_.empty() && "Contact points should never be empty");
-
-  if (random_) {
+  if (random_ && !contact_points_.empty()) {
     random_shuffle(contact_points_.begin(), contact_points_.end(), random_);
   }