Fix driver export and don't force static lib (#352)

* Don't force static library when building tests
* Use shared lib for export checks
* Fix and speed up CI `check_driver_exports()`
* Always define`dse_gssapi_authenticator_set_lock_callbacks()`

Author: mpenick

build.yaml

@@ -49,7 +49,7 @@ build:
 
       FUNCTIONS+=($(grep -Eoh '(^cass_\s*(\w+)\s*\()|(^dse_\s*(\w+)\s*\()' cpp-driver/include/dse.h | awk -F '(' '{print $1}'));
       FUNCTIONS+=($(grep -Eoh '^cass_\s*(\w+)\s*\(' cpp-driver/include/cassandra.h | awk -F '(' '{print $1}'))
-      check_driver_exports 'cpp-driver/build/libcassandra_static.a' "${FUNCTIONS[@]}"
+      check_driver_exports 'cpp-driver/build/libcassandra' "${FUNCTIONS[@]}"
 
       cpp-driver/build/cassandra-unit-tests --gtest_output=xml:unit-test-results.xml
 

cpp-driver/.build.sh

@@ -27,9 +27,11 @@ SHA=$(echo ${GIT_COMMIT} | cut -c1-7)
 
 SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )"
 if [ "${OS_NAME}" = "osx" ]; then
+  LIB_SUFFIX="dylib"
   PROCS=$(sysctl -n hw.logicalcpu)
   . ${SCRIPT_DIR}/.build.osx.sh
 else
+  LIB_SUFFIX="so"
   PROCS=$(grep -e '^processor' -c /proc/cpuinfo)
   . ${SCRIPT_DIR}/.build.linux.sh
 fi
@@ -79,7 +81,6 @@ build_driver() {
     fi
     cmake -DCMAKE_BUILD_TYPE=Release \
           -D${driver_prefix}_BUILD_SHARED=On \
-          -D${driver_prefix}_BUILD_STATIC=On \
           -D${driver_prefix}_BUILD_EXAMPLES=On \
           -D${driver_prefix}_BUILD_UNIT_TESTS=On \
           -D${driver_prefix}_BUILD_INTEGRATION_TESTS=${BUILD_INTEGRATION_TESTS} \
@@ -91,11 +92,13 @@ build_driver() {
 
 check_driver_exports() {(
   set +e  #Disable fail fast for this subshell
-  local driver_library=${1}
+  local driver_library="${1}.${LIB_SUFFIX}"
   if [ -f ${driver_library} ]; then
     declare -a MISSING_FUNCTIONS
+    local symbols_file=$(mktemp /tmp/driver_exports.XXXXXX)
+    nm ${driver_library} > $symbols_file
     for function in "${@:2}"; do
-      nm ${driver_library} | grep ${function} > /dev/null
+      grep ${function} $symbols_file > /dev/null
       if [ $? -ne 0 ]
       then
         MISSING_DEFINITION+=("${function}")

cpp-driver/CMakeLists.txt

@@ -55,7 +55,6 @@ if(CASS_BUILD_TESTS)
 endif()
 
 if(CASS_BUILD_INTEGRATION_TESTS OR CASS_BUILD_UNIT_TESTS)
-  set(CASS_BUILD_STATIC ON) # Required for tests
   set(CASS_USE_OPENSSL ON) # Required for tests
   set(CASS_USE_KERBEROS ON) # Required for tests
 endif()

cpp-driver/build.yaml

@@ -46,7 +46,7 @@ build:
 
       FUNCTIONS+=($(grep -Eoh '(^cass_\s*(\w+)\s*\()|(^dse_\s*(\w+)\s*\()' include/dse.h | awk -F '(' '{print $1}'));
       FUNCTIONS+=($(grep -Eoh '^cass_\s*(\w+)\s*\(' include/cassandra.h | awk -F '(' '{print $1}'))
-      check_driver_exports 'build/libcassandra_static.a' "${FUNCTIONS[@]}"
+      check_driver_exports 'build/libcassandra' "${FUNCTIONS[@]}"
 
       build/cassandra-unit-tests --gtest_output=xml:unit-test-results.xml
 

cpp-driver/src/dse_auth.cpp

@@ -14,6 +14,8 @@
   limitations under the License.
 */
 
+#include "dse.h"
+
 #include "dse_auth.hpp"
 #include "logger.hpp"
 
@@ -26,6 +28,21 @@ using namespace datastax;
 using namespace datastax::internal;
 using namespace datastax::internal::enterprise;
 
+extern "C" {
+
+CassError
+dse_gssapi_authenticator_set_lock_callbacks(DseGssapiAuthenticatorLockCallback lock_callback,
+                                            DseGssapiAuthenticatorUnlockCallback unlock_callback,
+                                            void* data) {
+#ifdef HAVE_KERBEROS
+  return DseGssapiAuthenticator::set_lock_callbacks(lock_callback, unlock_callback, data);
+#else
+  return CASS_ERROR_LIB_NOT_IMPLEMENTED;
+#endif
+}
+
+} // extern "C"
+
 bool DsePlainTextAuthenticator::initial_response(String* response) {
   if (class_name_ == DSE_AUTHENTICATOR) {
     response->assign(PLAINTEXT_AUTH_MECHANISM);

cpp-driver/src/gssapi/dse_auth_gssapi.cpp

@@ -40,17 +40,6 @@ using namespace datastax::internal::enterprise;
 static void dse_gssapi_authenticator_nop_lock(void* data) {}
 static void dse_gssapi_authenticator_nop_unlock(void* data) {}
 
-extern "C" {
-
-CassError
-dse_gssapi_authenticator_set_lock_callbacks(DseGssapiAuthenticatorLockCallback lock_callback,
-                                            DseGssapiAuthenticatorUnlockCallback unlock_callback,
-                                            void* data) {
-  return DseGssapiAuthenticator::set_lock_callbacks(lock_callback, unlock_callback, data);
-}
-
-} // extern "C"
-
 struct GssapiBuffer {
 public:
   gss_buffer_desc buffer;