Skip to content

Commit d9c9f29

Browse files
author
Michael Fero
committed
CPP-818 - Add configuration properties to Insights startup message
1 parent 8aeea5e commit d9c9f29

6 files changed

Lines changed: 19 additions & 1 deletion

File tree

cpp-driver/gtests/src/unit/tests/test_cluster.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,8 @@ class ClusterUnitTest : public EventLoopTest {
315315
return ClusterMetadataResolver::Ptr(new LocalDcClusterMetadataResolver(local_dc_));
316316
}
317317

318+
virtual const char* name() const { return "LocalDc"; }
319+
318320
private:
319321
String local_dc_;
320322
};

cpp-driver/gtests/src/unit/tests/test_session.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,8 @@ class SessionUnitTest : public EventLoopTest {
253253
return ClusterMetadataResolver::Ptr(new LocalDcClusterMetadataResolver(local_dc_));
254254
}
255255

256+
virtual const char* name() const { return "LocalDc"; }
257+
256258
private:
257259
String local_dc_;
258260
};

cpp-driver/src/cloud_secure_connection_config.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,8 @@ class CloudClusterMetadataResolverFactory : public ClusterMetadataResolverFactor
208208
settings.control_connection_settings.connection_settings.connect_timeout_ms));
209209
}
210210

211+
virtual const char* name() const { return "Cloud"; }
212+
211213
private:
212214
String host_;
213215
int port_;

cpp-driver/src/cluster_metadata_resolver.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ class ClusterMetadataResolverFactory : public RefCounted<ClusterMetadataResolver
7171

7272
virtual ~ClusterMetadataResolverFactory() {}
7373
virtual ClusterMetadataResolver::Ptr new_instance(const ClusterSettings& settings) const = 0;
74+
virtual const char* name() const = 0;
7475
};
7576

7677
/**
@@ -81,6 +82,7 @@ class ClusterMetadataResolverFactory : public RefCounted<ClusterMetadataResolver
8182
class DefaultClusterMetadataResolverFactory : public ClusterMetadataResolverFactory {
8283
public:
8384
virtual ClusterMetadataResolver::Ptr new_instance(const ClusterSettings& settings) const;
85+
virtual const char* name() const { return "Default"; }
8486
};
8587

8688
}}} // namespace datastax::internal::core

src/client_insights.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -499,6 +499,10 @@ class StartupMessageHandler : public RefCounted<StartupMessageHandler> {
499499
writer.Bool(config_.prepare_on_up_or_add_host());
500500
writer.Key("noCompact");
501501
writer.Bool(config_.no_compact());
502+
writer.Key("cloudSecureConnectBundleLoaded");
503+
writer.Bool(config_.cloud_secure_connection_config().is_loaded());
504+
writer.Key("clusterMetadataResolver");
505+
writer.String(config_.cluster_metadata_resolver_factory()->name());
502506
writer.EndObject(); // configuration
503507

504508
writer.EndObject(); // otherOptions

tests/src/unit/tests/test_client_insights.cpp

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ TEST_F(ClientInsightsUnitTest, StartupData) {
387387
ASSERT_TRUE(value.HasMember("configuration"));
388388
const json::Value& configuration = value["configuration"];
389389
ASSERT_TRUE(configuration.IsObject());
390-
ASSERT_EQ(24u, configuration.MemberCount());
390+
ASSERT_EQ(26u, configuration.MemberCount());
391391
ASSERT_TRUE(configuration.HasMember("protocolVersion"));
392392
ASSERT_EQ(config_.protocol_version().value(), configuration["protocolVersion"].GetInt());
393393
ASSERT_TRUE(configuration.HasMember("useBetaProtocol"));
@@ -441,6 +441,12 @@ TEST_F(ClientInsightsUnitTest, StartupData) {
441441
ASSERT_EQ(config_.prepare_on_up_or_add_host(), configuration["prepareOnUpOrAddHost"].GetBool());
442442
ASSERT_TRUE(configuration.HasMember("noCompact"));
443443
ASSERT_EQ(config_.no_compact(), configuration["noCompact"].GetBool());
444+
ASSERT_TRUE(configuration.HasMember("cloudSecureConnectBundleLoaded"));
445+
ASSERT_EQ(config_.cloud_secure_connection_config().is_loaded(),
446+
configuration["cloudSecureConnectBundleLoaded"].GetBool());
447+
ASSERT_TRUE(configuration.HasMember("clusterMetadataResolver"));
448+
ASSERT_STREQ(config_.cluster_metadata_resolver_factory()->name(),
449+
configuration["clusterMetadataResolver"].GetString());
444450
}
445451
{ // platform info
446452
ASSERT_TRUE(data.HasMember("platformInfo"));

0 commit comments

Comments
 (0)