Skip to content

Commit e77ab8d

Browse files
Michael Feromikefero
authored andcommitted
test: Adding help message for --keep-cluster and updating versions
* Removed requirement for keep cluster to have a value; it was meant to be a toggle originally.
1 parent b60d05f commit e77ab8d

3 files changed

Lines changed: 13 additions & 15 deletions

File tree

gtests/src/integration/options.cpp

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
#include <algorithm>
2424
#include <iostream>
2525

26-
#define DEFAULT_OPTIONS_CASSSANDRA_VERSION CCM::CassVersion("3.11.2")
27-
#define DEFAULT_OPTIONS_DSE_VERSION CCM::DseVersion("6.0.1")
26+
#define DEFAULT_OPTIONS_CASSSANDRA_VERSION CCM::CassVersion("3.11.3")
27+
#define DEFAULT_OPTIONS_DSE_VERSION CCM::DseVersion("6.0.3")
2828

2929
// Initialize the defaults for all the options
3030
bool Options::is_initialized_ = false;
@@ -87,14 +87,9 @@ bool Options::initialize(int argc, char* argv[]) {
8787
}
8888
// Integration test options
8989
if (key.compare("--keep-clusters") == 0) {
90-
if (!value.empty()) {
91-
is_keep_clusters_ = bool_value(value);
92-
}
93-
else {
94-
std::cerr << "Missing Keep Cluster(s) Boolean: Using default " << is_keep_clusters_ << std::endl;
95-
}
90+
is_keep_clusters_ = true;
9691
}
97-
if (key.compare("--log-tests") == 0) {
92+
else if (key.compare("--log-tests") == 0) {
9893
if (!value.empty()) {
9994
is_log_tests_ = bool_value(value);
10095
} else {
@@ -306,10 +301,10 @@ void Options::print_help() {
306301
<< "Password to use for DSE download authentication." << std::endl;
307302
std::cout << " --git" << std::endl << " "
308303
<< "Indicate Cassandra/DSE server download should be obtained from" << std::endl
309-
<< " ASF/GitHub." << std::endl;
304+
<< " ASF/GitHub." << std::endl;
310305
std::cout << " --git=[BRANCH_OR_TAG]" << std::endl << " "
311306
<< "Indicate Cassandra/DSE server branch/tag should be obtained from" << std::endl
312-
<<" ASF/GitHub." << std::endl;
307+
<< " ASF/GitHub." << std::endl;
313308
std::cout << " --install-dir=[INSTALL_DIR]" << std::endl << " "
314309
<< "Indicate Cassandra/DSE installation directory to use." << std::endl;
315310
std::cout << " --prefix=[PREFIX]" << std::endl << " "
@@ -335,6 +330,9 @@ void Options::print_help() {
335330
<< "Private key filename to use for remote deployment. The default is" << std::endl
336331
<< " " << private_key() << "." << std::endl;
337332
#endif
333+
std::cout << " --keep-clusters" << std::endl << " "
334+
<< "Indicate CCM clusters should not be removed after tests terminate."
335+
<< std::endl;
338336
std::cout << std::endl;
339337
}
340338

test/ccm_bridge/data/config.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#
1414
# Uncomment to specify Cassandra version
1515
##
16-
#CASSANDRA_VERSION=3.11.1
16+
#CASSANDRA_VERSION=3.11.3
1717
##
1818
# Flag to determine if Cassandra/DSE version should be obtained from ASF/GitHub
1919
#
@@ -64,7 +64,7 @@
6464
#
6565
# Uncomment to specify DSE version
6666
##
67-
#DSE_VERSION=6.0.1
67+
#DSE_VERSION=6.0.3
6868
##
6969
# CCM DSE Credentials Type (username_password|ini_file)
7070
#

test/ccm_bridge/src/bridge.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ typedef struct _LIBSSH2_CHANNEL LIBSSH2_CHANNEL;
4343
#endif
4444

4545
// Default values
46-
#define DEFAULT_CASSANDRA_VERSION CassVersion("3.11.2")
47-
#define DEFAULT_DSE_VERSION DseVersion("6.0.1")
46+
#define DEFAULT_CASSANDRA_VERSION CassVersion("3.11.3")
47+
#define DEFAULT_DSE_VERSION DseVersion("6.0.3")
4848
#define DEFAULT_USE_GIT false
4949
#define DEFAULT_USE_INSTALL_DIR false
5050
#define DEFAULT_USE_DSE false

0 commit comments

Comments
 (0)