SGA-11419 Skipping dialect methods and adding a comment on name if not exists supported by snowflake

Author: etgarperets

src/dialect/bigquery.rs

@@ -116,11 +116,6 @@ impl Dialect for BigQueryDialect {
         true
     }
 
-    // See https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#:~:text=CREATE%20%5B%20OR%20REPLACE%20%5D%20VIEW%20%5B%20IF%20NOT%20EXISTS%20%5D
-    fn create_view_if_not_exists_supported(&self) -> bool {
-        true
-    }
-
     fn require_interval_qualifier(&self) -> bool {
         true
     }

src/dialect/generic.rs

@@ -88,14 +88,6 @@ impl Dialect for GenericDialect {
         true
     }
 
-    fn create_view_if_not_exists_supported(&self) -> bool {
-        true
-    }
-
-    fn create_view_name_before_if_not_exists_supported(&self) -> bool {
-        true
-    }
-
     fn support_map_literal_syntax(&self) -> bool {
         true
     }

src/dialect/mod.rs

@@ -247,18 +247,6 @@ pub trait Dialect: Debug + Any {
         false
     }
 
-    /// Does the dialect support sql statements such as:
-    /// CREATE VIEW IF NOT EXISTS view_name AS SELECT * FROM table_name
-    fn create_view_if_not_exists_supported(&self) -> bool {
-        false
-    }
-
-    /// Does the dialect support view_name before IF NOT EXISTS in CREATE VIEW:
-    /// CREATE VIEW IF NOT EXISTS view_name AS SELECT * FROM table_name
-    fn create_view_name_before_if_not_exists_supported(&self) -> bool {
-        false
-    }
-
     /// Returns true if the dialect supports referencing another named window
     /// within a window clause declaration.
     ///

src/dialect/snowflake.rs

@@ -285,16 +285,6 @@ impl Dialect for SnowflakeDialect {
         true
     }
 
-    // See https://docs.snowflake.com/en/sql-reference/sql/create-view
-    fn create_view_if_not_exists_supported(&self) -> bool {
-        true
-    }
-
-    // Snowflake allows table name before if not exists in CREATE VIEW
-    fn create_view_name_before_if_not_exists_supported(&self) -> bool {
-        true
-    }
-
     fn supports_left_associative_joins_without_parens(&self) -> bool {
         false
     }

src/dialect/sqlite.rs

@@ -57,11 +57,6 @@ impl Dialect for SQLiteDialect {
         true
     }
 
-    // See https://www.sqlite.org/lang_createview.html
-    fn create_view_if_not_exists_supported(&self) -> bool {
-        true
-    }
-
     fn supports_start_transaction_modifier(&self) -> bool {
         true
     }

src/parser/mod.rs

@@ -5774,18 +5774,13 @@ impl<'a> Parser<'a> {
         let mut name_before_not_exists = false;
         if self.peek_keywords(&[Keyword::IF, Keyword::NOT, Keyword::EXISTS]) {
             // Possible syntax -> ... IF NOT EXISTS <name>
-            if self.dialect.create_view_if_not_exists_supported() {
-                if_not_exists = self.parse_keywords(&[Keyword::IF, Keyword::NOT, Keyword::EXISTS]);
-            }
+            if_not_exists = self.parse_keywords(&[Keyword::IF, Keyword::NOT, Keyword::EXISTS]);
             name = self.parse_object_name(allow_unquoted_hyphen)?;
         } else {
             // Possible syntax -> ... <name> IF NOT EXISTS
+            // Supported by snowflake but is undocumented
             name = self.parse_object_name(allow_unquoted_hyphen)?;
-            if self
-                .dialect
-                .create_view_name_before_if_not_exists_supported()
-                && self.parse_keywords(&[Keyword::IF, Keyword::NOT, Keyword::EXISTS])
-            {
+            if self.parse_keywords(&[Keyword::IF, Keyword::NOT, Keyword::EXISTS]) {
                 if_not_exists = true;
                 name_before_not_exists = true;
             }

tests/sqlparser_common.rs

@@ -16387,18 +16387,8 @@ fn parse_drop_stream() {
 
 #[test]
 fn parse_create_view_if_not_exists() {
-    let sql = "CREATE VIEW IF NOT EXISTS v AS SELECT 1";
-    let dialects = TestedDialects::new(vec![
-        Box::new(SnowflakeDialect {}),
-        Box::new(GenericDialect {}),
-        Box::new(SQLiteDialect {}),
-        Box::new(BigQueryDialect {}),
-    ]);
-    let _ = dialects.verified_stmt(sql);
+    let sql: &'static str = "CREATE VIEW IF NOT EXISTS v AS SELECT 1";
+    let _ = all_dialects().verified_stmt(sql);
     let sql = "CREATE VIEW v IF NOT EXISTS AS SELECT 1";
-    let dialects = TestedDialects::new(vec![
-        Box::new(SnowflakeDialect {}),
-        Box::new(GenericDialect {}),
-    ]);
-    let _ = dialects.verified_stmt(sql);
+    let _ = all_dialects().verified_stmt(sql);
 }