PR feedback: skip dialect methods

Author: achristmascarl

src/dialect/mod.rs

@@ -1060,20 +1060,6 @@ pub trait Dialect: Debug + Any {
     fn supports_space_separated_column_options(&self) -> bool {
         false
     }
-
-    /// Returns true if the dialect supports `ADD <table_constraint> [NOT VALID]` in `ALTER TABLE` statements.
-    ///
-    /// - [PostgreSQL](https://www.postgresql.org/docs/17/sql-altertable.html)
-    fn supports_constraint_not_valid(&self) -> bool {
-        false
-    }
-
-    /// Returns true if the dialect supports `VALIDATE CONSTRAINT <constraint_name>` in `ALTER TABLE` statements.
-    ///
-    /// - [PostgreSQL](https://www.postgresql.org/docs/17/sql-altertable.html)
-    fn supports_validate_constraint(&self) -> bool {
-        false
-    }
 }
 
 /// This represents the operators for which precedence must be defined

src/dialect/postgresql.rs

@@ -258,12 +258,4 @@ impl Dialect for PostgreSqlDialect {
     fn supports_set_names(&self) -> bool {
         true
     }
-
-    fn supports_constraint_not_valid(&self) -> bool {
-        true
-    }
-
-    fn supports_validate_constraint(&self) -> bool {
-        true
-    }
 }

src/parser/mod.rs

@@ -8477,10 +8477,7 @@ impl<'a> Parser<'a> {
     pub fn parse_alter_table_operation(&mut self) -> Result<AlterTableOperation, ParserError> {
         let operation = if self.parse_keyword(Keyword::ADD) {
             if let Some(constraint) = self.parse_optional_table_constraint()? {
-                let mut not_valid = false;
-                if self.dialect.supports_constraint_not_valid() {
-                    not_valid = self.parse_keywords(&[Keyword::NOT, Keyword::VALID]);
-                }
+                let not_valid = self.parse_keywords(&[Keyword::NOT, Keyword::VALID]);
                 AlterTableOperation::AddConstraint {
                     constraint,
                     not_valid,
@@ -8899,9 +8896,7 @@ impl<'a> Parser<'a> {
             };
 
             AlterTableOperation::ReplicaIdentity { identity }
-        } else if self.parse_keywords(&[Keyword::VALIDATE, Keyword::CONSTRAINT])
-            && self.dialect.supports_validate_constraint()
-        {
+        } else if self.parse_keywords(&[Keyword::VALIDATE, Keyword::CONSTRAINT]) {
             let name = self.parse_identifier()?;
             AlterTableOperation::ValidateConstraint { name }
         } else {

tests/sqlparser_postgres.rs

@@ -6235,7 +6235,7 @@ fn parse_ts_datatypes() {
 
 #[test]
 fn parse_alter_table_constraint_not_valid() {
-    match pg().verified_stmt(
+    match pg_and_generic().verified_stmt(
         "ALTER TABLE foo ADD CONSTRAINT bar FOREIGN KEY (baz) REFERENCES other(ref) NOT VALID",
     ) {
         Statement::AlterTable { operations, .. } => {
@@ -6262,7 +6262,7 @@ fn parse_alter_table_constraint_not_valid() {
 
 #[test]
 fn parse_alter_table_validate_constraint() {
-    match pg().verified_stmt("ALTER TABLE foo VALIDATE CONSTRAINT bar") {
+    match pg_and_generic().verified_stmt("ALTER TABLE foo VALIDATE CONSTRAINT bar") {
         Statement::AlterTable { operations, .. } => {
             assert_eq!(
                 operations,