Raneme InsertTableAlias to TableAliasWithoutColumns

Author: xitep

src/ast/dml.rs

@@ -30,10 +30,7 @@ use crate::{
 };
 
 use super::{
-    display_comma_separated, helpers::attached_token::AttachedToken, query::InputFormatClause,
-    Assignment, Expr, FromTable, Ident, InsertAliases, InsertTableAlias, MysqlInsertPriority,
-    ObjectName, OnInsert, OptimizerHint, OrderByExpr, Query, SelectInto, SelectItem, Setting,
-    SqliteOnConflict, TableFactor, TableObject, TableWithJoins, UpdateTableFromKind, Values,
+    Assignment, Expr, FromTable, Ident, InsertAliases, TableAliasWithoutColumns, MysqlInsertPriority, ObjectName, OnInsert, OptimizerHint, OrderByExpr, Query, SelectInto, SelectItem, Setting, SqliteOnConflict, TableFactor, TableObject, TableWithJoins, UpdateTableFromKind, Values, display_comma_separated, helpers::attached_token::AttachedToken, query::InputFormatClause
 };
 
 /// INSERT statement.
@@ -58,7 +55,7 @@ pub struct Insert {
     pub table: TableObject,
     /// `table_name as foo` (for PostgreSQL)
     /// `table_name foo` (for Oracle)
-    pub table_alias: Option<InsertTableAlias>,
+    pub table_alias: Option<TableAliasWithoutColumns>,
     /// COLUMNS
     pub columns: Vec<Ident>,
     /// Overwrite (Hive)

src/ast/mod.rs

@@ -6460,7 +6460,7 @@ pub struct InsertAliases {
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
 /// Optional alias for an `INSERT` table; i.e. the table to be inserted into
-pub struct InsertTableAlias {
+pub struct TableAliasWithoutColumns {
     /// `true` if the aliases was explicitly introduced with the "AS" keyword
     pub explicit: bool,
     /// the alias name itself

src/parser/mod.rs

@@ -17171,15 +17171,15 @@ impl<'a> Parser<'a> {
                     && self.peek_one_of_keywords(&[Keyword::DEFAULT, Keyword::VALUES]).is_none()
                 {
                     self.maybe_parse(|parser| parser.parse_identifier())?
-                        .map(|alias| InsertTableAlias {
+                        .map(|alias| TableAliasWithoutColumns {
                             explicit: false,
                             alias,
                         })
                 } else {
                     None
                 }
             } else if dialect_of!(self is PostgreSqlDialect) && self.parse_keyword(Keyword::AS) {
-                Some(InsertTableAlias {
+                Some(TableAliasWithoutColumns {
                     explicit: true,
                     alias: self.parse_identifier()?,
                 })

tests/sqlparser_oracle.rs

@@ -22,7 +22,7 @@ use pretty_assertions::assert_eq;
 
 use sqlparser::{
     ast::{
-        BinaryOperator, Expr, Ident, Insert, InsertTableAlias, ObjectName, QuoteDelimitedString,
+        BinaryOperator, Expr, Ident, Insert, TableAliasWithoutColumns, ObjectName, QuoteDelimitedString,
         Statement, TableObject, Value, ValueWithSpan,
     },
     dialect::OracleDialect,
@@ -426,7 +426,7 @@ fn test_insert_with_table_alias() {
         assert!(matches!(stmt,
             Statement::Insert(Insert {
                 table: TableObject::TableName(table_name),
-                table_alias: Some(InsertTableAlias {
+                table_alias: Some(TableAliasWithoutColumns {
                     explicit: false,
                     alias: Ident {
                         value: table_alias,

tests/sqlparser_postgres.rs

@@ -5445,7 +5445,7 @@ fn test_simple_postgres_insert_with_alias() {
                 quote_style: None,
                 span: Span::empty(),
             }])),
-            table_alias: Some(InsertTableAlias {
+            table_alias: Some(TableAliasWithoutColumns {
                 explicit: true,
                 alias: Ident {
                     value: "test_table".to_string(),
@@ -5605,7 +5605,7 @@ fn test_simple_insert_with_quoted_alias() {
                 quote_style: None,
                 span: Span::empty(),
             }])),
-            table_alias: Some(InsertTableAlias {
+            table_alias: Some(TableAliasWithoutColumns {
                 explicit: true,
                 alias: Ident {
                     value: "Test_Table".to_string(),