ffi_physical_optimizer_stabby_upgrade

Author: coderfender

datafusion/ffi/src/physical_optimizer.rs

@@ -214,8 +214,9 @@ impl PhysicalOptimizerRule for ForeignPhysicalOptimizerRule {
         let config_options: FFI_ConfigOptions = config.into();
         let plan = FFI_ExecutionPlan::new(plan, None);
 
-        let optimized_plan =
-            unsafe { df_result!((self.rule.optimize)(&self.rule, &plan, config_options))? };
+        let optimized_plan = unsafe {
+            df_result!((self.rule.optimize)(&self.rule, &plan, config_options))?
+        };
         (&optimized_plan).try_into()
     }
 

datafusion/ffi/tests/ffi_physical_optimizer.rs

@@ -38,12 +38,7 @@ mod tests {
     fn test_ffi_physical_optimizer_rule() -> Result<(), DataFusionError> {
         let module = get_module()?;
 
-        let ffi_rule = module.create_physical_optimizer_rule().ok_or(
-            DataFusionError::NotImplemented(
-                "External module failed to implement create_physical_optimizer_rule"
-                    .to_string(),
-            ),
-        )?();
+        let ffi_rule = (module.create_physical_optimizer_rule)();
 
         let foreign_rule: Arc<dyn PhysicalOptimizerRule + Send + Sync> =
             (&ffi_rule).into();