Commit 1e3b956
Minor: compute qualify window expressions only when QUALIFY clause is present (#21173)
## Which issue does this PR close?
Does not close but related #608
## Rationale for this change
Followup to #20963
@jonahgao had a feedback in
#20963 (comment)
to try to find qualify only if we are inside QUALIFY block. I did not
think it was this minor so thought followup would be better but this is
simply moving to if block to prevent unnecessary computation
## What changes are included in this PR?
Move `qualify_window_func_exprs` computation inside the QUALIFY block
## Are these changes tested?
Covered by existing tests from #20963.
## Are there any user-facing changes?
No
Co-authored-by: Jonah Gao <jonahgao@msn.com>1 parent 20434b0 commit 1e3b956
1 file changed
Lines changed: 5 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
293 | 293 | | |
294 | 294 | | |
295 | 295 | | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | 296 | | |
305 | 297 | | |
306 | 298 | | |
| |||
342 | 334 | | |
343 | 335 | | |
344 | 336 | | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
345 | 342 | | |
346 | 343 | | |
347 | 344 | | |
| |||
0 commit comments