Skip to content

Commit 31f1e16

Browse files
Address review comments
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
1 parent 276e49e commit 31f1e16

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

  • datafusion/spark/src/function/array

datafusion/spark/src/function/array/slice.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ impl ScalarUDFImpl for SparkSlice {
9292
mut func_args: ScalarFunctionArgs,
9393
) -> Result<ColumnarValue> {
9494
if func_args.args[0].data_type() == DataType::Null {
95-
return Ok::<ColumnarValue, DataFusionError>(func_args.args[0].clone());
96-
};
95+
return Ok(func_args.args[0].clone());
96+
}
9797

9898
let array_len = func_args
9999
.args
@@ -189,13 +189,13 @@ mod tests {
189189
];
190190

191191
let args = ScalarFunctionArgs {
192-
args: input_args.to_owned(),
192+
args: input_args,
193193
arg_fields: vec![Arc::new(Field::new(
194194
"item",
195-
List(FieldRef::new(Field::new("", DataType::Int64, true))),
195+
List(FieldRef::new(Field::new("f", DataType::Int64, true))),
196196
false,
197197
))],
198-
number_rows: 0,
198+
number_rows: 1,
199199
return_field: Arc::new(Field::new(
200200
"item",
201201
List(FieldRef::new(Field::new_list_field(DataType::Int64, true))),
@@ -205,6 +205,6 @@ mod tests {
205205
};
206206
let slice = SparkSlice::new();
207207
let result = slice.invoke_with_args(args).unwrap();
208-
assert!(result.to_array(1).unwrap() == Arc::new(NullArray::new(1)));
208+
assert_eq!(result.to_array(1).unwrap(), Arc::new(NullArray::new(1)));
209209
}
210210
}

0 commit comments

Comments
 (0)