Skip to content

Commit 447b2d2

Browse files
fix: use cardinality tests for string_to_array empty input and add missing test case
Use cardinality() to unambiguously verify empty arrays since Arrow's text format renders [""] identically to []. Add missing test for string_to_array('', '', 'x') covering all four is_empty checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 452a4dd commit 447b2d2

1 file changed

Lines changed: 14 additions & 10 deletions

File tree

datafusion/sqllogictest/test_files/array.slt

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8623,21 +8623,25 @@ SELECT string_to_array('abcxxxdef', 'xxx')
86238623
----
86248624
[abc, def]
86258625

8626-
# empty string input should return empty array (PostgreSQL compatibility)
8627-
query ?
8628-
SELECT string_to_array('', ',')
8626+
query I
8627+
SELECT cardinality(string_to_array('', ','))
86298628
----
8630-
[]
8629+
0
86318630

8632-
query ?
8633-
SELECT string_to_array('', '')
8631+
query I
8632+
SELECT cardinality(string_to_array('', ''))
86348633
----
8635-
[]
8634+
0
86368635

8637-
query ?
8638-
SELECT string_to_array('', ',', 'x')
8636+
query I
8637+
SELECT cardinality(string_to_array('', ',', 'x'))
86398638
----
8640-
[]
8639+
0
8640+
8641+
query I
8642+
SELECT cardinality(string_to_array('', '', 'x'))
8643+
----
8644+
0
86418645

86428646
query ?
86438647
SELECT string_to_array('abc', '')

0 commit comments

Comments
 (0)