Skip to content

Commit 496a4dd

Browse files
committed
fix: add missing ProducerKind arg to DynamicFilterPhysicalExpr::new in tests
1 parent c6c5afd commit 496a4dd

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

datafusion/physical-expr/src/expressions/dynamic_filters.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ mod test {
603603
#[test]
604604
fn test_snapshot() {
605605
let expr = lit(42) as Arc<dyn PhysicalExpr>;
606-
let dynamic_filter = DynamicFilterPhysicalExpr::new(vec![], Arc::clone(&expr));
606+
let dynamic_filter = DynamicFilterPhysicalExpr::new(vec![], Arc::clone(&expr), ProducerKind::HashJoin);
607607

608608
// Take a snapshot of the current expression
609609
let snapshot = dynamic_filter.snapshot().unwrap();
@@ -620,7 +620,7 @@ mod test {
620620
#[test]
621621
fn test_dynamic_filter_physical_expr_misbehaves_data_type_nullable() {
622622
let dynamic_filter =
623-
DynamicFilterPhysicalExpr::new(vec![], lit(42) as Arc<dyn PhysicalExpr>);
623+
DynamicFilterPhysicalExpr::new(vec![], lit(42) as Arc<dyn PhysicalExpr>, ProducerKind::HashJoin);
624624

625625
// First call to data_type and nullable should set the initial values.
626626
let initial_data_type = dynamic_filter.data_type(&Schema::empty()).unwrap();
@@ -811,7 +811,7 @@ mod test {
811811

812812
// Create filter with initial value
813813
let filter =
814-
DynamicFilterPhysicalExpr::new(vec![], lit(true) as Arc<dyn PhysicalExpr>);
814+
DynamicFilterPhysicalExpr::new(vec![], lit(true) as Arc<dyn PhysicalExpr>, ProducerKind::HashJoin);
815815

816816
// Compute hash BEFORE update
817817
let mut hasher_before = DefaultHasher::new();
@@ -845,9 +845,9 @@ mod test {
845845
fn test_identity_based_equality() {
846846
// Create two separate filters with identical initial expressions
847847
let filter1 =
848-
DynamicFilterPhysicalExpr::new(vec![], lit(true) as Arc<dyn PhysicalExpr>);
848+
DynamicFilterPhysicalExpr::new(vec![], lit(true) as Arc<dyn PhysicalExpr>, ProducerKind::HashJoin);
849849
let filter2 =
850-
DynamicFilterPhysicalExpr::new(vec![], lit(true) as Arc<dyn PhysicalExpr>);
850+
DynamicFilterPhysicalExpr::new(vec![], lit(true) as Arc<dyn PhysicalExpr>, ProducerKind::HashJoin);
851851

852852
// Different instances should NOT be equal even with same expression
853853
// because they have independent inner Arcs (different update lifecycles)
@@ -868,7 +868,7 @@ mod test {
868868
use std::hash::{Hash, Hasher};
869869

870870
let filter =
871-
DynamicFilterPhysicalExpr::new(vec![], lit(true) as Arc<dyn PhysicalExpr>);
871+
DynamicFilterPhysicalExpr::new(vec![], lit(true) as Arc<dyn PhysicalExpr>, ProducerKind::HashJoin);
872872

873873
// Compute hash twice for the same instance
874874
let hash1 = {

0 commit comments

Comments
 (0)