Commit 4e015db
authored
## Which issue does this PR close?
- Closes #21685.
## Rationale for this change
Per issue. `make_valid_utf8.rs` imports from `datafusion::logical_expr`,
but `datafusion` is only a dep of `datafusion-spark` behind the `core`
feature, so `cargo check -p datafusion-spark` and `cargo bench -p
datafusion-spark` both fail without `--all-features`. CI doesn't catch
it because `datafusion-sqllogictest` pins `datafusion-spark` with `core`
on.
## What changes are included in this PR?
Move the `ColumnarValue`, `Signature`, `Volatility` imports from
`datafusion::logical_expr` to `datafusion_expr`, which is already
imported a few lines below.
## Are these changes tested?
Covered by existing tests. Verified `cargo check -p datafusion-spark`,
`cargo check -p datafusion-spark --all-targets`, and `cargo bench -p
datafusion-spark` all succeed after the change, and `./dev/rust_lint.sh`
passes.
## Are there any user-facing changes?
No.
1 parent d1800db commit 4e015db
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
26 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
0 commit comments