ci fix

Author: akoshchiy

datafusion/core/tests/physical_optimizer/window_optimize.rs

@@ -50,6 +50,7 @@ mod test {
             &[],
             Arc::new(frame),
             None,
+            Arc::clone(&schema),
         );
 
         let bounded_agg_exec = BoundedWindowAggExec::try_new(

datafusion/expr/src/window_state.rs

@@ -26,7 +26,7 @@ use crate::{
 
 use arrow::{
     array::ArrayRef,
-    compute::{SortOptions, concat, concat_batches},
+    compute::{concat, concat_batches},
     datatypes::{DataType, SchemaRef},
     record_batch::RecordBatch,
 };
@@ -648,7 +648,7 @@ fn check_equality(current: &[ScalarValue], target: &[ScalarValue]) -> Result<boo
 mod tests {
     use super::*;
 
-    use arrow::array::Float64Array;
+    use arrow::{array::Float64Array, compute::SortOptions};
 
     fn get_test_data() -> (Vec<ArrayRef>, Vec<SortOptions>) {
         let range_columns: Vec<ArrayRef> = vec![Arc::new(Float64Array::from(vec![

datafusion/physical-expr/src/window/standard.rs

@@ -175,7 +175,6 @@ impl WindowExpr for StandardWindowExpr {
     ) -> Result<()> {
         let field = self.expr.field()?;
         let out_type = field.data_type();
-        let sort_options = self.order_by.iter().map(|o| o.options).collect::<Vec<_>>();
         // create a WindowAggState to clone when `window_agg_state` does not contain the respective
         // group, which is faster than potentially creating a new one at every iteration
         let new_state = WindowAggState::new(out_type)?;

datafusion/physical-optimizer/src/limit_pushdown_past_window.rs

@@ -316,6 +316,7 @@ mod tests {
                 WindowFrameBound::Preceding(ScalarValue::UInt64(None)),
                 WindowFrameBound::CurrentRow,
             )),
+            Arc::clone(&s),
         ));
 
         let window: Arc<dyn ExecutionPlan> = Arc::new(BoundedWindowAggExec::try_new(

datafusion/proto/tests/cases/roundtrip_physical_plan.rs

@@ -359,6 +359,7 @@ fn roundtrip_udwf() -> Result<()> {
             PhysicalSortExpr::new(col("b", &schema)?, SortOptions::new(true, true))
         ],
         Arc::new(WindowFrame::new(None)),
+        Arc::clone(&schema),
     ));
 
     let input = Arc::new(EmptyExec::new(schema.clone()));
@@ -402,6 +403,7 @@ fn roundtrip_window() -> Result<()> {
             },
         }],
         Arc::new(window_frame),
+        Arc::clone(&schema),
     ));
 
     let plain_aggr_window_expr = Arc::new(PlainAggregateWindowExpr::new(
@@ -417,6 +419,7 @@ fn roundtrip_window() -> Result<()> {
         &[],
         Arc::new(WindowFrame::new(None)),
         None,
+        Arc::clone(&schema),
     ));
 
     let window_frame = WindowFrame::new_bounds(
@@ -438,6 +441,7 @@ fn roundtrip_window() -> Result<()> {
         &[],
         Arc::new(window_frame),
         None,
+        Arc::clone(&schema),
     ));
 
     let input = Arc::new(EmptyExec::new(schema.clone()));
@@ -467,6 +471,7 @@ fn roundtrip_window_distinct() -> Result<()> {
         &[],                              // no order by
         Arc::new(WindowFrame::new(None)), // unbounded frame
         None,
+        Arc::clone(&schema),
     ));
 
     // Create a distinct sum window expression with bounded frame (becomes SlidingAggregateWindowExpr)
@@ -491,6 +496,7 @@ fn roundtrip_window_distinct() -> Result<()> {
         &[],                     // no order by
         Arc::new(bounded_frame), // bounded frame
         None,
+        Arc::clone(&schema),
     ));
 
     let input = Arc::new(EmptyExec::new(schema.clone()));
@@ -523,6 +529,7 @@ fn test_distinct_window_serialization_end_to_end() -> Result<()> {
         &[],
         Arc::new(WindowFrame::new(None)),
         None,
+        Arc::clone(&schema),
     ));
 
     // Test 2: DISTINCT SUM (without ignore nulls)
@@ -546,6 +553,7 @@ fn test_distinct_window_serialization_end_to_end() -> Result<()> {
         &[],
         Arc::new(bounded_frame),
         None,
+        Arc::clone(&schema),
     ));
 
     let input = Arc::new(EmptyExec::new(schema.clone()));
@@ -1384,6 +1392,7 @@ fn roundtrip_scalar_udf_extension_codec() -> Result<()> {
             &[],
             Arc::new(WindowFrame::new(None)),
             None,
+            Arc::clone(&schema),
         ))],
         filter,
         true,
@@ -1436,6 +1445,7 @@ fn roundtrip_udwf_extension_codec() -> Result<()> {
             },
         }],
         Arc::new(window_frame),
+        Arc::clone(&schema),
     ));
 
     let input = Arc::new(EmptyExec::new(schema.clone()));
@@ -1496,6 +1506,7 @@ fn roundtrip_aggregate_udf_extension_codec() -> Result<()> {
             &[],
             Arc::new(WindowFrame::new(None)),
             None,
+            Arc::clone(&schema),
         ))],
         filter,
         true,
@@ -3185,6 +3196,7 @@ fn roundtrip_lead_with_default_value() -> Result<()> {
             },
         }],
         Arc::new(WindowFrame::new(None)),
+        Arc::clone(&schema),
     ));
 
     let input = Arc::new(EmptyExec::new(schema.clone()));