You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: CDC review fixes — use i32 for norm_level, validate chunk sizes, clean up proto handling
- Change `CdcOptions::norm_level` from `i64` to `i32` to match parquet's type,
replacing `config_field!(i64)` with `config_field!(i32)` and removing all
now-unnecessary `as i32`/`as i64` casts
- Add validation in `into_writer_properties_builder` for invalid CDC config:
`min_chunk_size == 0` and `max_chunk_size <= min_chunk_size`, returning a
proper `DataFusionError::Configuration` instead of panicking in the parquet layer
- Add explanatory comments on why proto zero-value handling is asymmetric
between chunk sizes (0 is invalid) and `norm_level` (0 is valid default)
- Remove extra blank line in `ParquetOptions` config block
- Remove unused `parquet` feature from `datafusion-proto-common/Cargo.toml`
- Add three validation tests for the new error paths
0 commit comments