Commit 678d1ad
authored
Minor: Add comment explaining rationale to avoid dependencies on functions (#20667)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
Somewhat frequently PRs try and add a dependency (both codewise and
logically) to datafusion-functions in the datafusion-optimizer crate
This then gets flagged during code review, which is somewhat frustrating
probably for the submitter as they didn't know. This most recently
happened here
https://github.com/apache/datafusion/pull/20610/changes#r2877698578
Thus let's try and document that attempt in comments
## What changes are included in this PR?
Add comments to the relevant Cargo.toml file
## Are these changes tested?
N/A
## Are there any user-facing changes?
No this is a development process change only1 parent b3976d6 commit 678d1ad
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
46 | 54 | | |
47 | 55 | | |
48 | 56 | | |
| |||
0 commit comments