Skip to content

Commit 8058404

Browse files
committed
introduced new data type & changed storage format so that we no longer need to meta-data about nulls
1 parent dd37d18 commit 8058404

3 files changed

Lines changed: 190 additions & 1393 deletions

File tree

datafusion/physical-plan/src/aggregates/group_values/mod.rs

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -264,21 +264,16 @@ pub fn new_group_values(
264264
}
265265

266266
fn supported_single_dictionary_value(t: &DataType) -> bool {
267-
matches!(
268-
t,
269-
DataType::Utf8
270-
| DataType::LargeUtf8
271-
| DataType::Binary
272-
| DataType::LargeBinary
273-
| DataType::Utf8View
274-
| DataType::BinaryView
275-
| DataType::Int8
276-
| DataType::Int16
277-
| DataType::Int32
278-
| DataType::Int64
279-
| DataType::UInt8
280-
| DataType::UInt16
281-
| DataType::UInt32
282-
| DataType::UInt64
283-
)
267+
match t {
268+
DataType::Utf8 | DataType::LargeUtf8 | DataType::Utf8View => true,
269+
DataType::List(field)
270+
if matches!(
271+
field.data_type(),
272+
DataType::Utf8 | DataType::Utf8View | DataType::LargeUtf8
273+
) =>
274+
{
275+
true
276+
}
277+
_ => false,
278+
}
284279
}

0 commit comments

Comments
 (0)