Skip to content

Commit 8725d5c

Browse files
committed
update test doc
1 parent f998b1a commit 8725d5c

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

datafusion/sqllogictest/test_files/window.slt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2425,11 +2425,9 @@ SELECT c9, rn1 FROM (SELECT c9,
24252425
145294611 96
24262426

24272427
# test_c9_rn_ordering_alias_opposite_direction3
2428-
# These test check for whether datafusion is aware of the ordering of the column generated by ROW_NUMBER() window function.
2429-
# Physical plan should have a SortExec after BoundedWindowAggExec.
2430-
# The reason is that ordering of the table after BoundedWindowAggExec can be described as rn1 ASC, and also c9 DESC.
2431-
# However, the requirement is rn1 ASC, c9 ASC (lexicographical order). Hence existing ordering cannot satisfy requirement
2432-
# (Requirement is finer than existing ordering)
2428+
# These tests check whether DataFusion tracks the ordering of the column generated by ROW_NUMBER() window function.
2429+
# The outer ORDER BY can be simplified by ordering equivalence, so the plan should not need an additional SortExec
2430+
# beyond the one required to satisfy the window input order.
24332431
query TT
24342432
EXPLAIN SELECT c9, rn1 FROM (SELECT c9,
24352433
ROW_NUMBER() OVER(ORDER BY c9 DESC) as rn1

0 commit comments

Comments
 (0)