Commit aad61ce
committed
fix: only reverse/cumulate when reorder succeeds (prevents ClickBench regression)
Reverse and cumulative pruning from DynamicFilter now only trigger
when reorder_optimizer is Some (the sort column was found in parquet
stats). For GROUP BY + ORDER BY queries, the sort column is an
aggregate output not in parquet — reorder bails out, so reverse and
cumulative prune should also skip. Previously, reverse ran regardless,
changing I/O patterns with no benefit (Q23 2x slower in ClickBench).1 parent ca94342 commit aad61ce
1 file changed
Lines changed: 10 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1221 | 1221 | | |
1222 | 1222 | | |
1223 | 1223 | | |
1224 | | - | |
1225 | | - | |
1226 | | - | |
1227 | | - | |
| 1224 | + | |
| 1225 | + | |
| 1226 | + | |
1228 | 1227 | | |
1229 | | - | |
1230 | | - | |
1231 | | - | |
1232 | | - | |
1233 | | - | |
1234 | | - | |
| 1228 | + | |
| 1229 | + | |
| 1230 | + | |
| 1231 | + | |
| 1232 | + | |
| 1233 | + | |
| 1234 | + | |
1235 | 1235 | | |
1236 | 1236 | | |
1237 | 1237 | | |
| |||
0 commit comments