Skip to content

Commit afa0502

Browse files
authored
Merge branch 'main' into feat_migrate_ffi_to_stabby
2 parents 48926f9 + d530276 commit afa0502

251 files changed

Lines changed: 5890 additions & 1442 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/extended.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,10 @@ jobs:
173173
ref: ${{ github.event.inputs.pr_head_sha }} # will be empty if triggered by push
174174
submodules: true
175175
fetch-depth: 1
176-
- name: Setup Rust toolchain
177-
uses: ./.github/actions/setup-builder
178-
with:
179-
rust-version: stable
176+
# Don't use setup-builder to avoid configuring RUST_BACKTRACE which is expensive
177+
- name: Install protobuf compiler
178+
run: |
179+
apt-get update && apt-get install -y protobuf-compiler
180180
- name: Run sqllogictest
181181
run: |
182182
cargo test --features backtrace,parquet_encryption --profile ci-optimized --test sqllogictests -- --include-sqlite

AGENTS.md

Lines changed: 10 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,33 +2,22 @@
22

33
## Developer Documentation
44

5+
- [Quick Start Setup](docs/source/contributor-guide/development_environment.md#quick-start)
6+
- [Testing Quick Start](docs/source/contributor-guide/testing.md#testing-quick-start)
7+
- [Before Submitting a PR](docs/source/contributor-guide/index.md#before-submitting-a-pr)
58
- [Contributor Guide](docs/source/contributor-guide/index.md)
69
- [Architecture Guide](docs/source/contributor-guide/architecture.md)
710

811
## Before Committing
912

10-
Before committing any changes, you **must** run the following checks and fix any issues:
13+
Before committing any changes, you MUST follow the instructions in
14+
[Before Submitting a PR](docs/source/contributor-guide/index.md#before-submitting-a-pr)
15+
and ensure the required checks listed there pass. Do not commit code that
16+
fails any of those checks.
1117

12-
```bash
13-
cargo fmt --all
14-
cargo clippy --all-targets --all-features -- -D warnings
15-
```
16-
17-
- `cargo fmt` ensures consistent code formatting across the project.
18-
- `cargo clippy` catches common mistakes and enforces idiomatic Rust patterns. All warnings must be resolved (treated as errors via `-D warnings`).
19-
20-
Do not commit code that fails either of these checks.
18+
When creating a PR, you MUST follow the [PR template](.github/pull_request_template.md).
2119

2220
## Testing
2321

24-
Run relevant tests before submitting changes:
25-
26-
```bash
27-
cargo test --all-features
28-
```
29-
30-
For SQL logic tests:
31-
32-
```bash
33-
cargo test -p datafusion-sqllogictest
34-
```
22+
See the [Testing Quick Start](docs/source/contributor-guide/testing.md#testing-quick-start)
23+
for the recommended pre-PR test commands.

0 commit comments

Comments
 (0)