Skip to content

Commit c6104a2

Browse files
committed
feat(tests): enhance dictionary array tests with raw values extraction
- Added `AsArray` import for `DictionaryArray` to facilitate raw values extraction. - Updated tests to include assertions for raw minimum values from the dictionary array, improving test coverage and validation accuracy.
1 parent 2669a30 commit c6104a2

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • datafusion/functions-aggregate-common/src

datafusion/functions-aggregate-common/src/min_max.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -911,7 +911,7 @@ pub fn max_batch(values: &ArrayRef) -> Result<ScalarValue> {
911911
#[cfg(test)]
912912
mod tests {
913913
use super::*;
914-
use arrow::array::DictionaryArray;
914+
use arrow::array::{AsArray, DictionaryArray};
915915
use std::sync::Arc;
916916

917917
#[test]
@@ -997,6 +997,8 @@ mod tests {
997997
let keys = Int8Array::from(vec![Some(1), None, Some(1), Some(1)]);
998998
let values = Arc::new(StringArray::from(vec!["zzz", "bbb", "aaa"]));
999999
let array = Arc::new(DictionaryArray::new(keys, values)) as ArrayRef;
1000+
let raw_values = array.as_any_dictionary().values();
1001+
let raw_min = min_batch(raw_values)?;
10001002

10011003
let min = min_batch(&array)?;
10021004
let max = max_batch(&array)?;
@@ -1006,6 +1008,8 @@ mod tests {
10061008
Box::new(ScalarValue::Utf8(Some("bbb".to_string()))),
10071009
);
10081010

1011+
assert_ne!(raw_min, expected);
1012+
10091013
assert_eq!(min, expected);
10101014
assert_eq!(max, expected);
10111015

0 commit comments

Comments
 (0)