feat: refactor min_max to utilize choose_min_max for improved internal matching

- Removed the call to min_max_scalar within min_max function.
- Implemented internal matching using choose_min_max!($OP).
- Updated return values to provide Ok with min or max based on Ordering result.
- Added unreachable!() for Ordering::Equal case for error handling.

Author: kosiew

datafusion/functions-aggregate-common/src/min_max.rs

@@ -141,6 +141,18 @@ macro_rules! min_max_generic {
     }};
 }
 
+macro_rules! min_max {
+    ($VALUE:expr, $DELTA:expr, $OP:ident) => {{
+        match choose_min_max!($OP) {
+            Ordering::Greater => Ok(min_max_scalar_impl!($VALUE, $DELTA, min)),
+            Ordering::Less => Ok(min_max_scalar_impl!($VALUE, $DELTA, max)),
+            Ordering::Equal => {
+                unreachable!("min/max comparisons do not use equal ordering")
+            }
+        }
+    }};
+}
+
 // min/max of two logically compatible scalar values.
 // Dictionary scalars participate by comparing their inner logical values.
 // When both inputs are dictionaries, matching key types are preserved in the
@@ -464,10 +476,6 @@ fn min_max_scalar(
     }
 }
 
-macro_rules! min_max {
-    ($VALUE:expr, $DELTA:expr, $OP:ident) => {{ min_max_scalar($VALUE, $DELTA, choose_min_max!($OP)) }};
-}
-
 /// Finds the min/max by scanning logical rows via `ScalarValue::try_from_array`.
 ///
 /// This path is required for dictionary arrays because comparing