Skip to content

Commit e0d3aaa

Browse files
committed
reduced PR
1 parent 680d0e6 commit e0d3aaa

File tree

2 files changed

+155
-2737
lines changed

2 files changed

+155
-2737
lines changed

datafusion/physical-plan/src/aggregates/group_values/mod.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
// Licensed to the Apache Software Foundation (ASF) under one
2-
// or more contributor license agreements. See the NOTICE file
1+
// Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file
32
// distributed with this work for additional information
43
// regarding copyright ownership. The ASF licenses this file
54
// to you under the Apache License, Version 2.0 (the
@@ -31,8 +30,8 @@ use datafusion_expr::EmitTo;
3130

3231
pub mod multi_group_by;
3332

34-
pub mod row;
35-
pub mod single_group_by;
33+
mod row;
34+
mod single_group_by;
3635
use datafusion_physical_expr::binary_map::OutputType;
3736
use multi_group_by::GroupValuesColumn;
3837
use row::GroupValuesRows;
@@ -231,7 +230,6 @@ pub fn new_group_values(
231230
Ok(Box::new(GroupValuesColumn::<true>::try_new(schema)?))
232231
}
233232
} else {
234-
// TODO: add specialized implementation for dictionary encoding columns for 2+ group by columns case
235233
Ok(Box::new(GroupValuesRows::try_new(schema)?))
236234
}
237235
}

0 commit comments

Comments
 (0)