remove duplicated test

Author: xiedeyantu

datafusion/core/tests/sql/aggregates/basic.rs

@@ -175,83 +175,6 @@ async fn count_aggregated_cube() -> Result<()> {
     Ok(())
 }
 
-#[tokio::test]
-async fn duplicate_grouping_sets_are_preserved() -> Result<()> {
-    let ctx = SessionContext::new();
-    let schema = Arc::new(Schema::new(vec![
-        Field::new("deptno", DataType::Int32, false),
-        Field::new("job", DataType::Utf8, true),
-        Field::new("sal", DataType::Int32, true),
-        Field::new("comm", DataType::Int32, true),
-    ]));
-    let batch = RecordBatch::try_new(
-        Arc::clone(&schema),
-        vec![
-            Arc::new(Int32Array::from(vec![10, 20])),
-            Arc::new(StringArray::from(vec![Some("CLERK"), Some("MANAGER")])),
-            Arc::new(Int32Array::from(vec![1300, 3000])),
-            Arc::new(Int32Array::from(vec![None, None])),
-        ],
-    )?;
-    let provider = MemTable::try_new(Arc::clone(&schema), vec![vec![batch]])?;
-    ctx.register_table("dup_grouping_sets", Arc::new(provider))?;
-
-    let results = plan_and_collect(
-        &ctx,
-        "
-        SELECT deptno, job, sal, sum(comm) AS sum_comm,
-               grouping(deptno) AS deptno_flag,
-               grouping(job) AS job_flag,
-               grouping(sal) AS sal_flag
-        FROM dup_grouping_sets
-        GROUP BY GROUPING SETS ((deptno, job), (deptno, sal), (deptno, job))
-        ORDER BY deptno, job, sal, deptno_flag, job_flag, sal_flag
-        ",
-    )
-    .await?;
-
-    assert_eq!(results.len(), 1);
-    assert_snapshot!(batches_to_string(&results), @r"
-    +--------+---------+------+----------+-------------+----------+----------+
-    | deptno | job     | sal  | sum_comm | deptno_flag | job_flag | sal_flag |
-    +--------+---------+------+----------+-------------+----------+----------+
-    | 10     | CLERK   |      |          | 0           | 0        | 1        |
-    | 10     | CLERK   |      |          | 0           | 0        | 1        |
-    | 10     |         | 1300 |          | 0           | 1        | 0        |
-    | 20     | MANAGER |      |          | 0           | 0        | 1        |
-    | 20     | MANAGER |      |          | 0           | 0        | 1        |
-    | 20     |         | 3000 |          | 0           | 1        | 0        |
-    +--------+---------+------+----------+-------------+----------+----------+
-    ");
-
-    let results = plan_and_collect(
-        &ctx,
-        "
-        SELECT deptno, job, sal,
-               grouping(deptno, job, sal) AS grouping_id
-        FROM dup_grouping_sets
-        GROUP BY GROUPING SETS ((deptno, job), (deptno, sal), (deptno, job))
-        ORDER BY deptno, job, sal, grouping_id
-        ",
-    )
-    .await?;
-
-    assert_eq!(results.len(), 1);
-    assert_snapshot!(batches_to_string(&results), @r"
-    +--------+---------+------+-------------+
-    | deptno | job     | sal  | grouping_id |
-    +--------+---------+------+-------------+
-    | 10     | CLERK   |      | 1           |
-    | 10     | CLERK   |      | 1           |
-    | 10     |         | 1300 | 2           |
-    | 20     | MANAGER |      | 1           |
-    | 20     | MANAGER |      | 1           |
-    | 20     |         | 3000 | 2           |
-    +--------+---------+------+-------------+
-    ");
-    Ok(())
-}
-
 async fn run_count_distinct_integers_aggregated_scenario(
     partitions: Vec<Vec<(&str, u64)>>,
 ) -> Result<Vec<RecordBatch>> {

datafusion/physical-plan/src/aggregates/mod.rs

@@ -2264,23 +2264,23 @@ mod tests {
             | a | b   | __grouping_id | __grouping_ordinal | COUNT(1)[count] |
             +---+-----+---------------+--------------------+-----------------+
             |   | 1.0 | 2             | 0                  | 1               |
-            |   | 1.0 | 2             | 1                  | 1               |
+            |   | 1.0 | 2             | 0                  | 1               |
+            |   | 2.0 | 2             | 0                  | 1               |
             |   | 2.0 | 2             | 0                  | 1               |
-            |   | 2.0 | 2             | 1                  | 1               |
             |   | 3.0 | 2             | 0                  | 1               |
-            |   | 3.0 | 2             | 1                  | 1               |
+            |   | 3.0 | 2             | 0                  | 1               |
             |   | 4.0 | 2             | 0                  | 1               |
-            |   | 4.0 | 2             | 1                  | 1               |
+            |   | 4.0 | 2             | 0                  | 1               |
+            | 2 |     | 1             | 0                  | 1               |
             | 2 |     | 1             | 0                  | 1               |
-            | 2 |     | 1             | 1                  | 1               |
             | 2 | 1.0 | 0             | 0                  | 1               |
-            | 2 | 1.0 | 0             | 1                  | 1               |
+            | 2 | 1.0 | 0             | 0                  | 1               |
             | 3 |     | 1             | 0                  | 1               |
-            | 3 |     | 1             | 1                  | 2               |
+            | 3 |     | 1             | 0                  | 2               |
             | 3 | 2.0 | 0             | 0                  | 2               |
             | 3 | 3.0 | 0             | 0                  | 1               |
             | 4 |     | 1             | 0                  | 1               |
-            | 4 |     | 1             | 1                  | 2               |
+            | 4 |     | 1             | 0                  | 2               |
             | 4 | 3.0 | 0             | 0                  | 1               |
             | 4 | 4.0 | 0             | 0                  | 2               |
             +---+-----+---------------+--------------------+-----------------+