feat[expr-common]: add REE arithmetic coercion for numeric and decimal (#21179)

## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes #123` indicates that this PR will close issue #123.
-->

- Closes #21178

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
Fix planning error

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
Match arms for REE types

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Yes

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Queries that would previously return an error on REE columns now pass.

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>

Author: asubiotto

datafusion/expr-common/src/type_coercion/binary.rs

@@ -378,6 +378,16 @@ fn math_decimal_coercion(
             let (lhs_type, value_type) = math_decimal_coercion(lhs_type, value_type)?;
             Some((lhs_type, value_type))
         }
+        (RunEndEncoded(_, field), _) => {
+            let (value_type, rhs_type) =
+                math_decimal_coercion(field.data_type(), rhs_type)?;
+            Some((value_type, rhs_type))
+        }
+        (_, RunEndEncoded(_, field)) => {
+            let (lhs_type, value_type) =
+                math_decimal_coercion(lhs_type, field.data_type())?;
+            Some((lhs_type, value_type))
+        }
         (
             Null,
             Decimal32(_, _) | Decimal64(_, _) | Decimal128(_, _) | Decimal256(_, _),
@@ -1414,6 +1424,15 @@ fn mathematics_numerical_coercion(
         (_, Dictionary(_, value_type)) => {
             mathematics_numerical_coercion(lhs_type, value_type)
         }
+        (RunEndEncoded(_, lhs_field), RunEndEncoded(_, rhs_field)) => {
+            mathematics_numerical_coercion(lhs_field.data_type(), rhs_field.data_type())
+        }
+        (RunEndEncoded(_, field), _) => {
+            mathematics_numerical_coercion(field.data_type(), rhs_type)
+        }
+        (_, RunEndEncoded(_, field)) => {
+            mathematics_numerical_coercion(lhs_type, field.data_type())
+        }
         _ => numerical_coercion(lhs_type, rhs_type),
     }
 }
@@ -1493,6 +1512,15 @@ fn both_numeric_or_null_and_numeric(lhs_type: &DataType, rhs_type: &DataType) ->
         (_, Dictionary(_, value_type)) => {
             lhs_type.is_numeric() && value_type.is_numeric()
         }
+        (RunEndEncoded(_, lhs_field), RunEndEncoded(_, rhs_field)) => {
+            lhs_field.data_type().is_numeric() && rhs_field.data_type().is_numeric()
+        }
+        (RunEndEncoded(_, field), _) => {
+            field.data_type().is_numeric() && rhs_type.is_numeric()
+        }
+        (_, RunEndEncoded(_, field)) => {
+            lhs_type.is_numeric() && field.data_type().is_numeric()
+        }
         _ => lhs_type.is_numeric() && rhs_type.is_numeric(),
     }
 }

datafusion/expr-common/src/type_coercion/binary/tests/run_end_encoded.rs

@@ -16,11 +16,17 @@
 // under the License.
 
 use super::*;
+use DataType::*;
+
+fn ree(value_type: DataType) -> DataType {
+    RunEndEncoded(
+        Arc::new(Field::new("run_ends", Int32, false)),
+        Arc::new(Field::new("values", value_type, false)),
+    )
+}
 
 #[test]
 fn test_ree_type_coercion() {
-    use DataType::*;
-
     let lhs_type = RunEndEncoded(
         Arc::new(Field::new("run_ends", Int8, false)),
         Arc::new(Field::new("values", Int32, false)),
@@ -97,3 +103,29 @@ fn test_ree_type_coercion() {
         Some(rhs_type.clone())
     );
 }
+
+#[test]
+fn test_ree_arithmetic_coercion() -> Result<()> {
+    test_coercion_binary_rule!(ree(Int64), Int64, Operator::Plus, Int64);
+    test_coercion_binary_rule!(Int64, ree(Int64), Operator::Multiply, Int64);
+    test_coercion_binary_rule!(ree(Int32), ree(Int64), Operator::Plus, Int64);
+
+    // Decimal unwrapping through math_decimal_coercion
+    let (lhs, rhs) =
+        BinaryTypeCoercer::new(&ree(Decimal128(10, 2)), &Operator::Plus, &Int32)
+            .get_input_types()?;
+    assert_eq!(lhs, Decimal128(10, 2));
+    assert_eq!(rhs, Decimal128(10, 0));
+
+    let (lhs, rhs) =
+        BinaryTypeCoercer::new(&Int32, &Operator::Plus, &ree(Decimal128(10, 2)))
+            .get_input_types()?;
+    assert_eq!(lhs, Decimal128(10, 0));
+    assert_eq!(rhs, Decimal128(10, 2));
+
+    let result =
+        BinaryTypeCoercer::new(&ree(Utf8), &Operator::Plus, &Int32).get_input_types();
+    assert!(result.is_err());
+
+    Ok(())
+}

datafusion/sqllogictest/test_files/run_end_encoded.slt

@@ -55,3 +55,15 @@ FROM sensor_readings;
 ----
 sensor_A
 sensor_B
+
+# Test arithmetic on REE columns (numeric and decimal value types)
+query IR rowsort
+SELECT
+    arrow_cast(temperature, 'RunEndEncoded("run_ends": non-null Int32, "values": Int64)') + 1 AS t_plus_one,
+    arrow_cast(arrow_cast(temperature, 'Decimal128(10, 2)'), 'RunEndEncoded("run_ends": non-null Int32, "values": Decimal128(10, 2))') + 1 AS t_dec_plus_one
+FROM sensor_readings;
+----
+21 21
+23 23
+24 24
+25 25