GH-3499: Make cacheHashCode private (review suggestion)

iemejia · arouel · web-flow · commit e1c3ed9883b2 · 2026-04-19T19:03:59.000+02:00
Co-authored-by: André Rouél &lt;andre.rouel@gmail.com&gt;
diff --git a/parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java b/parquet-column/src/main/java/org/apache/parquet/io/api/Binary.java
@@ -118,7 +118,7 @@ public boolean equals(Object obj) {
    * a single int field with sentinel {@code 0} to remain race-safe without volatile.
    * If the computed hash is {@code 0}, no caching occurs and the next call recomputes.
    */
-  final int cacheHashCode(int hashCode) {
+  private int cacheHashCode(int hashCode) {
     if (!isBackingBytesReused) {
       cachedHashCode = hashCode;
     }

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ public boolean equals(Object obj) {`
`118`	`118`	`* a single int field with sentinel {@code 0} to remain race-safe without volatile.`
`119`	`119`	`* If the computed hash is {@code 0}, no caching occurs and the next call recomputes.`
`120`	`120`	`*/`
`121`		`- final int cacheHashCode(int hashCode) {`
	`121`	`+ private int cacheHashCode(int hashCode) {`
`122`	`122`	`if (!isBackingBytesReused) {`
`123`	`123`	`cachedHashCode = hashCode;`
`124`	`124`	`}`