Skip to content

Commit 060e4dc

Browse files
authored
[ISSUE #9743] Fix ReceiptHandleProcessorTest (#9744)
1 parent 1c83b11 commit 060e4dc

1 file changed

Lines changed: 23 additions & 5 deletions

File tree

proxy/src/test/java/org/apache/rocketmq/proxy/processor/ReceiptHandleProcessorTest.java

Lines changed: 23 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,38 @@
1818

1919
import io.netty.channel.local.LocalChannel;
2020
import org.apache.rocketmq.broker.client.ClientChannelInfo;
21-
import org.apache.rocketmq.broker.client.ConsumerIdsChangeListener;
21+
import org.apache.rocketmq.broker.client.ConsumerManager;
2222
import org.apache.rocketmq.common.consumer.ReceiptHandle;
2323
import org.apache.rocketmq.common.message.MessageClientIDSetter;
2424
import org.apache.rocketmq.proxy.common.ContextVariable;
2525
import org.apache.rocketmq.proxy.common.MessageReceiptHandle;
2626
import org.apache.rocketmq.proxy.common.ProxyContext;
2727
import org.apache.rocketmq.proxy.config.ConfigurationManager;
28+
import org.apache.rocketmq.proxy.config.InitConfigTest;
2829
import org.apache.rocketmq.proxy.config.ProxyConfig;
29-
import org.apache.rocketmq.remoting.protocol.subscription.SubscriptionGroupConfig;
30+
import org.apache.rocketmq.proxy.service.ServiceManager;
31+
import org.apache.rocketmq.proxy.service.metadata.MetadataService;
3032
import org.junit.Before;
3133
import org.junit.Test;
34+
import org.junit.runner.RunWith;
35+
import org.mockito.Mock;
3236
import org.mockito.Mockito;
37+
import org.mockito.junit.MockitoJUnitRunner;
38+
39+
import static org.mockito.Mockito.when;
40+
41+
@RunWith(MockitoJUnitRunner.class)
42+
public class ReceiptHandleProcessorTest extends InitConfigTest {
43+
44+
@Mock
45+
protected MessagingProcessor messagingProcessor;
46+
@Mock
47+
protected ServiceManager serviceManager;
48+
@Mock
49+
protected ConsumerManager consumerManager;
50+
@Mock
51+
protected MetadataService metadataService;
3352

34-
public class ReceiptHandleProcessorTest extends BaseProcessorTest {
3553
private static final ProxyContext PROXY_CONTEXT = ProxyContext.create();
3654
private static final String CONSUMER_GROUP = "consumerGroup";
3755
private static final String TOPIC = "topic";
@@ -49,6 +67,8 @@ public class ReceiptHandleProcessorTest extends BaseProcessorTest {
4967
@Before
5068
public void before() throws Throwable {
5169
super.before();
70+
when(serviceManager.getConsumerManager()).thenReturn(consumerManager);
71+
when(serviceManager.getMetadataService()).thenReturn(metadataService);
5272
this.receiptHandleProcessor = new ReceiptHandleProcessor(this.messagingProcessor, this.serviceManager);
5373
ProxyConfig config = ConfigurationManager.getProxyConfig();
5474
String receiptHandle = ReceiptHandle.builder()
@@ -64,7 +84,6 @@ public void before() throws Throwable {
6484
.build().encode();
6585
PROXY_CONTEXT.withVal(ContextVariable.CLIENT_ID, "channel-id");
6686
PROXY_CONTEXT.withVal(ContextVariable.CHANNEL, new LocalChannel());
67-
Mockito.doNothing().when(consumerManager).appendConsumerIdsChangeListener(Mockito.any(ConsumerIdsChangeListener.class));
6887
messageReceiptHandle = new MessageReceiptHandle(CONSUMER_GROUP, TOPIC, QUEUE_ID, receiptHandle, MESSAGE_ID, OFFSET,
6988
RECONSUME_TIMES);
7089
}
@@ -73,7 +92,6 @@ public void before() throws Throwable {
7392
public void testStart() throws Exception {
7493
receiptHandleProcessor.start();
7594
receiptHandleProcessor.addReceiptHandle(PROXY_CONTEXT, PROXY_CONTEXT.getChannel(), CONSUMER_GROUP, MSG_ID, messageReceiptHandle);
76-
Mockito.when(metadataService.getSubscriptionGroupConfig(Mockito.any(), Mockito.eq(CONSUMER_GROUP))).thenReturn(new SubscriptionGroupConfig());
7795
Mockito.when(consumerManager.findChannel(Mockito.eq(CONSUMER_GROUP), Mockito.eq(PROXY_CONTEXT.getChannel()))).thenReturn(Mockito.mock(ClientChannelInfo.class));
7896
Mockito.verify(messagingProcessor, Mockito.timeout(10000).times(1))
7997
.changeInvisibleTime(Mockito.any(ProxyContext.class), Mockito.any(ReceiptHandle.class), Mockito.eq(MESSAGE_ID),

0 commit comments

Comments
 (0)