Skip to content

Commit 2ad07d9

Browse files
committed
fix
Change-Id: I9274ca9ede5e6fb206dba362b653224447c79a40
1 parent 4a84ab7 commit 2ad07d9

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

broker/src/main/java/org/apache/rocketmq/broker/processor/NotificationProcessor.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import io.netty.channel.ChannelHandlerContext;
2121
import java.util.Map;
2222
import java.util.Random;
23+
import org.apache.commons.lang3.StringUtils;
2324
import org.apache.rocketmq.broker.BrokerController;
2425
import org.apache.rocketmq.broker.filter.ConsumerFilterData;
2526
import org.apache.rocketmq.broker.filter.ConsumerFilterManager;
@@ -151,7 +152,9 @@ public RemotingCommand processRequest(final ChannelHandlerContext ctx,
151152

152153
SubscriptionData subscriptionData = null;
153154
ExpressionMessageFilter messageFilter = null;
154-
if (brokerConfig.isUseMessageFilterForNotification() && requestHeader.getExp() != null && !requestHeader.getExp().isEmpty()) {
155+
if (brokerConfig.isUseMessageFilterForNotification() &&
156+
StringUtils.isNotEmpty(requestHeader.getExpType()) &&
157+
StringUtils.isNotEmpty(requestHeader.getExp())) {
155158
try {
156159
// origin topic
157160
subscriptionData = FilterAPI.build(
@@ -254,7 +257,9 @@ private boolean hasMsgFromQueue(String targetTopic, NotificationRequestHeader re
254257
}
255258
ReferredIterator<CqUnit> iterator = null;
256259
try {
257-
iterator = queue.iterateFrom(offset, maxFilterMessageNum);
260+
// In order to take into account both the file CQ and the Rocksdb CQ,
261+
// the count passed here is 32.
262+
iterator = queue.iterateFrom(offset, 32);
258263
if (iterator != null) {
259264
while (iterator.hasNext()) {
260265
CqUnit cqUnit = iterator.next();

0 commit comments

Comments
 (0)