Skip to content

Commit 3a184c3

Browse files
authored
[ISSUE #10021] Optimize consumer type check with EnumSet (#10022)
1 parent 24ca9e4 commit 3a184c3

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

auth/src/main/java/org/apache/rocketmq/auth/authorization/builder/DefaultAuthorizationContextBuilder.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import java.util.ArrayList;
4040
import java.util.Arrays;
4141
import java.util.Collections;
42+
import java.util.EnumSet;
4243
import java.util.HashMap;
4344
import java.util.List;
4445
import org.apache.commons.collections.CollectionUtils;
@@ -85,6 +86,8 @@ public class DefaultAuthorizationContextBuilder implements AuthorizationContextB
8586
private static final String B = "b";
8687
private static final String CONSUMER_GROUP = "consumerGroup";
8788
private final AuthConfig authConfig;
89+
private static final EnumSet<ClientType> CONSUMER_CLIENT_TYPES =
90+
EnumSet.of(ClientType.PUSH_CONSUMER, ClientType.SIMPLE_CONSUMER, ClientType.PULL_CONSUMER);
8891

8992
private final RequestHeaderRegistry requestHeaderRegistry;
9093

@@ -438,8 +441,7 @@ private static List<DefaultAuthorizationContext> newContext(Metadata metadata, T
438441
}
439442

440443
private boolean isConsumerClientType(ClientType clientType) {
441-
return Arrays.asList(ClientType.PUSH_CONSUMER, ClientType.SIMPLE_CONSUMER, ClientType.PULL_CONSUMER)
442-
.contains(clientType);
444+
return CONSUMER_CLIENT_TYPES.contains(clientType);
443445
}
444446

445447
private static List<DefaultAuthorizationContext> newPubContext(Metadata metadata, apache.rocketmq.v2.Resource topic) {

0 commit comments

Comments
 (0)