Skip to content

Commit c197e50

Browse files
guyinyouguyinyou
andauthored
[ISSUE #10079] FlushConsumeQueueService: always flush store checkpoint after CQ flush (#10080)
Change-Id: I57c0922bb81c2d43359867e82a92fdf2deab7ad7 Co-authored-by: guyinyou <guyinyou.gyy@alibaba-inc.com>
1 parent 1754cec commit c197e50

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

store/src/main/java/org/apache/rocketmq/store/queue/ConsumeQueueStore.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -651,22 +651,20 @@ private void doFlush(int retryTimes) {
651651
logicsMsgTimestamp = messageStore.getStoreCheckpoint().getTmpLogicsMsgTimestamp();
652652
}
653653

654-
boolean flushOK = true;
655654
for (ConcurrentMap<Integer, ConsumeQueueInterface> maps : consumeQueueTable.values()) {
656655
for (ConsumeQueueInterface cq : maps.values()) {
657656
boolean result = false;
658657
for (int i = 0; i < retryTimes && !result; i++) {
659658
result = flush(cq, flushConsumeQueueLeastPages);
660659
}
661-
flushOK &= result;
662660
}
663661
}
664662

665663
if (messageStoreConfig.isEnableCompaction()) {
666664
messageStore.getCompactionStore().flush(flushConsumeQueueLeastPages);
667665
}
668666

669-
if (flushOK && 0 == flushConsumeQueueLeastPages) {
667+
if (0 == flushConsumeQueueLeastPages) {
670668
if (logicsMsgTimestamp > 0) {
671669
messageStore.getStoreCheckpoint().setLogicsMsgTimestamp(logicsMsgTimestamp);
672670
}

0 commit comments

Comments
 (0)